Skip to content

[codex] Keep deployed wall out of taskbar#7

Merged
appaKappaK merged 1 commit intomainfrom
codex/fix-wall-taskbar-icon
Apr 2, 2026
Merged

[codex] Keep deployed wall out of taskbar#7
appaKappaK merged 1 commit intomainfrom
codex/fix-wall-taskbar-icon

Conversation

@appaKappaK
Copy link
Copy Markdown
Owner

@appaKappaK appaKappaK commented Apr 2, 2026

Summary\n- keep the deployed wall window out of Linux taskbar/dock surfaces\n- extract the wall window config into a small helper with regression coverage\n- note the taskbar/tray-style icon fix in the changelog\n\n## Verification\n- npm run lint\n- npm test\n- npm run smoke:actions\n

Summary by CodeRabbit

  • Bug Fixes

    • Wall window no longer appears in the Linux taskbar/dock, eliminating the duplicate tray-style icon alongside the main console.
  • Tests

    • Added test coverage for window configuration options.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4b9b8f79-69d4-4fca-8bd9-8da61567cbea

📥 Commits

Reviewing files that changed from the base of the PR and between fe45674 and b56e2d1.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • src/lib/window-options.js
  • src/main.js
  • test/window-options.test.js

📝 Walkthrough

Walkthrough

A wall window configuration builder function is extracted into a dedicated module, incorporating a skipTaskbar: true flag to prevent Linux taskbar display. The main application refactored to use this builder, and comprehensive tests added to validate the configuration output.

Changes

Cohort / File(s) Summary
Documentation
CHANGELOG.md
Unreleased changelog entry documenting that wall windows now skip taskbar display on Linux, preventing duplicate tray icons.
Window Configuration
src/lib/window-options.js
New buildWallWindowOptions() function constructs BrowserWindow options with bounds, dimensions, UI flags (frame: false, autoHideMenuBar: true, skipTaskbar: true), styling (backgroundColor: "#02050a"), and security settings (contextIsolation: true, nodeIntegration: false).
Main Application Refactor
src/main.js
Refactored createWallWindow() to delegate window options construction to buildWallWindowOptions(), reducing inline configuration and improving separation of concerns.
Testing
test/window-options.test.js
New test file validates that buildWallWindowOptions() correctly preserves bounds, applies required flags (skipTaskbar, contextIsolation), and configures web preferences.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Windows hide from taskbar's view,
Configuration clean and true,
Refactored code flows neat and bright,
Wall displays without the sight!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-wall-taskbar-icon

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@appaKappaK appaKappaK merged commit 02fc6c7 into main Apr 2, 2026
2 of 3 checks passed
@appaKappaK appaKappaK deleted the codex/fix-wall-taskbar-icon branch April 2, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant