Skip to content

Add support for providing configuration to player persistence implementations #412

Description

@garyttierney

The current implementation of player loading/saving in Apollo relies on the persistence providers having a no-args constructor, making implementation of persistence providers that rely on external systems troublesome.

For example, a persistence provider that uses a JDBC connection to load data from a SQL database will likely want to pool its connections. To achieve this the implementation would need to share the pool via static state, which makes testing difficult and the code obtuse.

Solutions:

  • Bootstrap the server using a fully-fledged Dependency Injection framework (Guice?)
  • Extend the PlayerLoader XML reader with support for passing in configuration parameters/other objects.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    low priorityRequires no immediate fixneeds-discussionThe project maintainers request input from users

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions