This repository was archived by the owner on Aug 4, 2023. It is now read-only.
Fix Issue 486: For a POST with body taking an array of strings, elements of the array can be improperly coerced into numeric values. - #499
Open
mlitwin wants to merge 2 commits into
Conversation
added 2 commits
April 14, 2017 13:49
… when body is array. In swagger 2, a parameter in body will have a .schema, rather than be a schema: http://swagger.io/specification/#parameterObject getParameterType() is already savvy to this, so we do what it does for the schema. Without this, you get a bogus schema, which eventually leads to converValue thinnking it's got an object type (the default), and attempting to JSON.stringify the nice string into an object.
Member
|
I'll give it a peek when releasing in a few days. |
cbayram
reviewed
Jan 3, 2018
There was a problem hiding this comment.
There are other places in the function where schema assumes top-level definition. How about resolving the schema level at the beginning of the function?
if (schema.schema) {
schema = schema.schema;
}
val = mHelpers.convertValue(val, schema, mHelpers.getParameterType(schema), location);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In swagger 2, a parameter in body will have a .schema, rather than be a schema: http://swagger.io/specification/#parameterObject
getParameterType() is already savvy to this, so we do what it does for the schema.
Without this, you get a bogus schema, which eventually leads to converValue thinnking it's got an object type (the default), and attempting to JSON.stringify the nice string into an object.