Skip to content

Enable private vulnerability reporting, secret scanning, and push protection #4

Open

Description

@kinlane

This project exists because a supply-chain report went unanswered. Right now there is no private channel to report a vulnerability to this fork.

Current state on this repository:

Setting State
Private vulnerability reporting disabled
Secret scanning disabled
Secret scanning push protection disabled
Dependabot security updates disabled

The last three matter concretely because the release workflow is designed to hold an NPM_TOKEN. A publish credential in a repository with no secret scanning and no push protection is exactly the failure this project criticised upstream for.

Acceptance criteria

  • Private vulnerability reporting enabled
  • Secret scanning enabled
  • Push protection enabled
  • Dependabot security updates enabled
  • Confirmed that a report submitted through the private channel reaches someone

Minutes of work, and it closes an open hypocrisy. Related: the SECURITY.md task.

Activity

  1. kinlane commented on Aug 3, 2026

    @kinlane
    ContributorAuthor

    Done. All four enabled today.

    Before:

    {"dependabot_security_updates":{"status":"disabled"},
     "secret_scanning":{"status":"disabled"},
     "secret_scanning_push_protection":{"status":"disabled"}}

    After:

    {"dependabot_security_updates":{"status":"enabled"},
     "secret_scanning":{"status":"enabled"},
     "secret_scanning_push_protection":{"status":"enabled"}}

    Private vulnerability reporting is on, and SECURITY.md in #19 now routes reporters to it as the preferred channel with info@apicommons.org as the alternative.

    • Private vulnerability reporting enabled
    • Secret scanning enabled
    • Push protection enabled
    • Dependabot security updates enabled
    • Confirmed that a report submitted through the private channel reaches someone

    The last box is not ticked, and it should not be ticked until someone has actually sent a test report through the private advisory flow and watched it arrive. Enabling a setting and verifying a channel are different claims, and this project of all projects should not conflate them.

    Two settings could not be enabled: secret_scanning_non_provider_patterns and secret_scanning_validity_checks both stayed disabled after a successful PATCH, so they appear to need entitlements this repository does not have. Not blocking, and noted here so the gap is on the record rather than assumed handled.

  2. kinlane commented on Aug 27, 2026

    @kinlane
    ContributorAuthor

    Checked 2026-08-27. All four acceptance criteria are already satisfied on this repository.

    Setting State
    Private vulnerability reporting enabled
    Secret scanning enabled
    Secret scanning push protection enabled
    Dependabot security updates enabled

    The table in the issue body describes a state that no longer exists — all four were turned on at some point after it was filed, and nothing recorded it here.

    • Private vulnerability reporting enabled
    • Secret scanning enabled
    • Push protection enabled
    • Dependabot security updates enabled
    • Confirmed that a report submitted through the private channel reaches someone

    That last box is the one still genuinely open, and it is the one the issue cares about most: "This project exists because a supply-chain report went unanswered." The channel is live; nobody has sent anything through it. One test report from an account that is not the maintainer's would close this properly. Until then the setting is enabled and the claim is untested — which is a smaller version of the same gap.

    Two adjacent notes from today:

    • The concern about NPM_TOKEN sitting in a repository without secret scanning is resolved by the settings above. The release path has a separate defect though — release.yml was granting safe.directory to upstream's checkout path, so the release job would have failed before it could push. Fixed in fix(repo): release.yml grants safe.directory to the upstream path #74.
    • spotlight-spec had none of these four enabled. All four are on there now, and SECURITY.md is in spotlight-spec#36.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    taskConcrete unit of work

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions