Repository navigation
Build CI the way GitHub Pages does, so CI predicts the deploy - #8
Merged
Merged
Conversation
CI pins jekyll ~> 4.4 while Pages runs github-pages 232 (Jekyll 3.10), so CI cannot see the class of failure roadmap.md already warns about in a comment: Jekyll 3.10's where_exp takes one comparison and then demands end-of-string, and `and` / `or` inside it is Jekyll 4 only. spotlight-spec proved the cost of that gap — the same mistake there kept pages-build-deployment red for 20+ commits with CI green throughout and the site serving a week-old build. Add a second job that builds against .github/Gemfile.pages, deliberately unpinned. Nothing here needs fixing first: every template in this repo already parses under Jekyll 3.10. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to api-commons/spotlight-spec#16. Nothing is broken here — this closes the gap that let it break there unnoticed.
The gap
Gemfilepinsjekyll ~> 4.4;pages-build-deploymentignores it and runs thegithub-pagesgem (232 → Jekyll 3.10). CI has therefore never built what actually deploys.roadmap.mdalready carries a comment about the specific trap — Jekyll 3.10'swhere_expparses one comparison and then demands end-of-string, soand/orinside the expression is Jekyll 4 only. That comment is institutional memory with nothing enforcing it.In
spotlight-specthe same mistake kept Pages red for 20+ consecutive commits while CI was green the entire time andspec.spotlight-rules.comquietly served a week-old build. The only visible symptom was a site that stopped updating.The change
A second CI job that builds against
.github/Gemfile.pages— thegithub-pagesgem, deliberately unpinned, since tracking whatever Pages currently resolves to is the point. The existing Jekyll 4 job stays; it's what a localjekyll servedoes.No content changes are needed first: every template in this repo already parses cleanly under Jekyll 3.10 semantics (verified by running Jekyll 3.10's own
parse_conditionover everywhere_exp, plus aLiquid::Template.parseof every.md/.html).Branched off
main, so it doesn't touch the in-flightpost/2026-08-04-ci-told-usbranch.🤖 Generated with Claude Code