fix: make fflib_MethodCountRecorder fields and methods non-static#166
Open
fransf-wtax wants to merge 1 commit into
Open
fix: make fflib_MethodCountRecorder fields and methods non-static#166fransf-wtax wants to merge 1 commit into
fransf-wtax wants to merge 1 commit into
Conversation
This prevents loss of recorded invocations after an asynchronous flow runs as part of a unit test.
Author
|
@ImJohnMDaniel Should I log an issue for this as well or is just the PR fine? |
ImJohnMDaniel
requested review from
ImJohnMDaniel,
afawcett and
john-storey-devops
Contributor
@fransf-wtax - yes, that would be helpful and would allow you to add more information related to the issue that you have seen. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents loss of recorded invocations after an asynchronous flow runs as part of a unit test.
This ZIP file contains a small SFDX project that demonstrates the problem with the current ApexMocks code.
platform-event-mock-issue.zip
The proposed change would save the recorded method method invocations in a non-static variable, which Salesforce does preserve correctly when an asynchronous flow runs as part of a unit test.
This change is