[YUNIKORN-3105] move release staging out of the tools directory#206
Open
kousei47747 wants to merge 1 commit intoapache:masterfrom
Open
[YUNIKORN-3105] move release staging out of the tools directory#206kousei47747 wants to merge 1 commit intoapache:masterfrom
kousei47747 wants to merge 1 commit intoapache:masterfrom
Conversation
wilfred-s
requested changes
Nov 26, 2025
Contributor
wilfred-s
left a comment
There was a problem hiding this comment.
Please rebase the change and two minor remarks..
.gitignore
Outdated
| target | ||
| *.swp | ||
| *.tmp | ||
| /build/ No newline at end of file |
Contributor
There was a problem hiding this comment.
NIT: missing newline at the end of the file, please add
a1e24ca to
050a9e7
Compare
Author
|
Hi @wilfred-s thanks for reviewing and sorry for the late replay, I've been dealing with some personal matters recently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Move the generated artifacts from release scripts to a new
builddirectory like used in all other repos.What type of PR is it?
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-3105