XALANC-743: transform with broken supplementary characters#42
Open
yhyacinth wants to merge 1 commit intoapache:masterfrom
Open
XALANC-743: transform with broken supplementary characters#42yhyacinth wants to merge 1 commit intoapache:masterfrom
yhyacinth wants to merge 1 commit intoapache:masterfrom
Conversation
Fix FunctionSubstring implementation to count the string data length considering the surrogate pair
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you transform when Unicode supplementary characters is included in the input, the output will be corrupted. I also confirmed that both Xalan-C++ versions 1.10 to 1.12 have the same problem.
I found something suspicious in the XPath FunctionSubstring implementation and fixed it.
Please refer to the issue tracker for a detailed description.