Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds/updates Javadoc to remove a TODO and better describe JSON serialization helpers in the execution plan model (addresses #63).
Changes:
- Replaces the
ExecutionPlan.toJsonList()TODO with descriptive Javadoc. - Adds Javadoc to
ExecutionStage.toJsonMap()describing its JSON-serializable map output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
wayang-commons/wayang-core/src/main/java/org/apache/wayang/core/plan/executionplan/ExecutionStage.java |
Adds Javadoc for toJsonMap() (map representation for JSON serialization). |
wayang-commons/wayang-core/src/main/java/org/apache/wayang/core/plan/executionplan/ExecutionPlan.java |
Replaces TODO with Javadoc for toJsonList() (list of stage maps). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...mons/wayang-core/src/main/java/org/apache/wayang/core/plan/executionplan/ExecutionStage.java
Outdated
Show resolved
Hide resolved
...mmons/wayang-core/src/main/java/org/apache/wayang/core/plan/executionplan/ExecutionPlan.java
Outdated
Show resolved
Hide resolved
…e/plan/executionplan/ExecutionStage.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…e/plan/executionplan/ExecutionPlan.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #63
This is warm up for my GSoC :)