test(relax): cover TFLite LOG and GREATER_EQUAL in test_frontend_tflite#19343
Merged
tlopex merged 3 commits intoapache:mainfrom Apr 4, 2026
Merged
test(relax): cover TFLite LOG and GREATER_EQUAL in test_frontend_tflite#19343tlopex merged 3 commits intoapache:mainfrom
tlopex merged 3 commits intoapache:mainfrom
Conversation
Contributor
Dayuxiaoshui
commented
Apr 4, 2026
Dayuxiaoshui
commented
- Extend test_element_wise with tf.math.log -> R.log.
- Extend test_split_compare with tf.math.greater_equal -> R.greater_equal, matching the existing split-tensor compare pattern and bool Expected IR. [Tracking Issue][TFLite] Expand unit test coverage for supported non-quantized operators #18971
Contributor
Author
|
cc @tlopex |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds test cases for the log and greater_equal operators in the TFLite frontend for Relax. The review feedback suggests further increasing test coverage by including the tan and greater operators, which are supported but currently missing from the test suites.
- Extend test_element_wise with tf.math.log -> R.log. - Extend test_split_compare with tf.math.greater_equal -> R.greater_equal, matching the existing split-tensor compare pattern and bool Expected IR.
Address review feedback: cover unary TAN in test_element_wise and binary GREATER in test_split_compare, alongside existing trig/compare ops.
tf.math.tan emits a custom TFLite op under TFLITE_BUILTINS + SELECT_TF_OPS, which Relax from_tflite rejects in check_unsupported_ops. Builtin TAN remains mapped in the frontend when present.
tlopex
approved these changes
Apr 4, 2026
Member
tlopex
left a comment
tlopex
left a comment
There was a problem hiding this comment.
Don't forget to put [] at the beginning of your title :)
Contributor
Author
no problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.