Skip to content

[TFLite][Frontend] Add expected IRModule checks for conv2d, pool2d, and batch_matmul tests#18970

Merged
MasterJH5574 merged 4 commits intoapache:mainfrom
tlopex:tf22
Apr 4, 2026
Merged

[TFLite][Frontend] Add expected IRModule checks for conv2d, pool2d, and batch_matmul tests#18970
MasterJH5574 merged 4 commits intoapache:mainfrom
tlopex:tf22

Conversation

@tlopex
Copy link
Copy Markdown
Member

@tlopex tlopex commented Apr 3, 2026

as per title

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the TFLite frontend tests for Relax by introducing explicit Expected IR modules for Conv2D, Pool2D, and BatchMatMul operations, allowing for stricter verification of the generated IR. Feedback identifies a potential inconsistency in the out_layout attribute for pooling operations that may cause structural equality failures. It is also suggested to maintain consistency by explicitly specifying the count_include_pad attribute across all pooling test cases.

@tlopex tlopex changed the title [Relax][TFLite] Add expected IRModule checks for conv2d, pool2d, and batch_matmul tests [TFLite][Frontend] Add expected IRModule checks for conv2d, pool2d, and batch_matmul tests Apr 3, 2026
@MasterJH5574 MasterJH5574 merged commit e3dda23 into apache:main Apr 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants