[TIKA-3420] Set tesseract ocr langauges as docker build args by mhf-ir · Pull Request #2 · apache/tika-docker

mhf-ir · 2020-12-15T08:35:27Z

Ability to user build docker with list of tesseract-ocr-[lang] as build args.

mhf-ir · 2020-12-15T08:47:26Z

Seems be docker-build.sh also must be update. for accept <TESSERACT_LANGUAGES>

dameikle

Thanks for this PR, this will be a great addition to tika-docker!

I've got a few comments as it looks like this may not work as intended, so wondering if you could take a look at them.

Thanks,
Dave

docker-tool.sh

mhf-ir · 2021-01-01T17:15:21Z

Change the build for rest of parameters and fix echo problem.

Also some change in README.md using Markdown lint and this changes, change my PR if needed for grammer or etc problem.

Thanks for your attention

mhf-ir · 2021-05-24T09:33:34Z

@dameikle Could you please look at this? Any problem, issue, changes? This simple patch will help me a lot.

lewismc

Hi @mhf-ir I like this pull request. Please consider my feedback. Thank you

README.md

docker-tool.sh

mhf-ir

:like:

mhf-ir · 2021-05-26T19:06:43Z

Seems TIKA_JAR_NAME also added, please check it.

lewismc · 2021-06-05T17:25:54Z

@mhf-ir OK I tried out the new patch today

./docker-tool.sh build 1.26 tika-1.27-tesseract-french.jar tesseract-ocr-fra

...

 => ERROR [dependencies 1/2] RUN DEBIAN_FRONTEND=noninteractive apt-get -y install openjdk-14-jre-headless gdal-bin tesseract-ocr 'tesseract-ocr-fra'                                                                                    1.4s
------
 > [dependencies 1/2] RUN DEBIAN_FRONTEND=noninteractive apt-get -y install openjdk-14-jre-headless gdal-bin tesseract-ocr 'tesseract-ocr-fra':
#6 0.293 Reading package lists...
#6 1.103 Building dependency tree...
#6 1.268 Reading state information...
#6 1.383 E: Unable to locate package 'tesseract-ocr-fra'
------
executor failed running [/bin/sh -c DEBIAN_FRONTEND=noninteractive apt-get -y install $JRE gdal-bin tesseract-ocr $TESSERACT_LANGUAGES]: exit code: 100

Is this the correct way to invoke ./docker-tool.sh's build command?

mhf-ir · 2021-06-06T11:59:01Z

@lewismc seems be problem for multiple packages name for build-args. i will try to find better way for that.

mhf-ir · 2021-06-07T16:09:57Z

@lewismc Try this, must be okey

./docker-tool.sh build 1.26 jar-alt-name tesseract-ocr-fra tesseract-ocr-fas

lewismc · 2021-06-07T19:54:25Z

This doesn't work either @mhf-ir

./docker-tool.sh build 1.26 jar-alt-name tesseract-ocr-fra
...
#9 9.069 --2021-06-07 19:53:48--  https://www.apache.org/dyn/closer.cgi/tika/jar-alt-name-1.26.jar?filename=tika/jar-alt-name-1.26.jar&action=download
#9 9.070 Resolving www.apache.org (www.apache.org)... 207.244.88.140, 95.216.26.30, 2a01:4f9:2a:1a61::2
#9 9.178 Connecting to www.apache.org (www.apache.org)|207.244.88.140|:443... connected.
#9 9.400 HTTP request sent, awaiting response... 404 Not Found
#9 10.63 2021-06-07 19:53:49 ERROR 404: Not Found.
#9 10.63
#9 10.64 --2021-06-07 19:53:49--  https://archive.apache.org/dist/tika/jar-alt-name-1.26.jar
#9 10.64 Resolving archive.apache.org (archive.apache.org)... 138.201.131.134, 2a01:4f8:172:2ec5::2
#9 10.74 Connecting to archive.apache.org (archive.apache.org)|138.201.131.134|:443... connected.
#9 12.28 HTTP request sent, awaiting response... 404 Not Found
#9 12.50 2021-06-07 19:53:51 ERROR 404: Not Found.
#9 12.50
------
executor failed running [/bin/sh -c DEBIAN_FRONTEND=noninteractive apt-get -y install gnupg2 wget     && wget -t 10 --max-redirect 1 --retry-connrefused -qO- https://downloads.apache.org/tika/KEYS | gpg --import     && wget -t 10 --max-redirect 1 --retry-connrefused $NEAREST_TIKA_SERVER_URL -O /${TIKA_JAR_NAME}-${TIKA_VERSION}.jar || rm /${TIKA_JAR_NAME}-${TIKA_VERSION}.jar     && sh -c "[ -f /${TIKA_JAR_NAME}-${TIKA_VERSION}.jar ]" || wget $ARCHIVE_TIKA_SERVER_URL -O /${TIKA_JAR_NAME}-${TIKA_VERSION}.jar || rm /${TIKA_JAR_NAME}-${TIKA_VERSION}.jar     && sh -c "[ -f /${TIKA_JAR_NAME}-${TIKA_VERSION}.jar ]" || exit 1     && wget -t 10 --max-redirect 1 --retry-connrefused $DEFAULT_TIKA_SERVER_ASC_URL -O /${TIKA_JAR_NAME}-${TIKA_VERSION}.jar.asc  || rm /${TIKA_JAR_NAME}-${TIKA_VERSION}.jar.asc     && sh -c "[ -f /${TIKA_JAR_NAME}-${TIKA_VERSION}.jar.asc ]" || wget $ARCHIVE_TIKA_SERVER_ASC_URL -O /${TIKA_JAR_NAME}-${TIKA_VERSION}.jar.asc || rm /${TIKA_JAR_NAME}-${TIKA_VERSION}.jar.asc     && sh -c "[ -f /${TIKA_JAR_NAME}-${TIKA_VERSION}.jar.asc ]" || exit 1;]: exit code: 1

mhf-ir · 2021-06-08T04:20:26Z

seems $jar variable has problem, default is tika-server
https://github.com/apache/tika-docker/blob/master/docker-tool.sh#L61
It's not my modification. I just resolve that conflict like master.

gpg: Total number processed: 7
gpg:               imported: 7
gpg: no ultimately trusted keys found
--2021-06-08 04:16:59--  https://www.apache.org/dyn/closer.cgi/tika/tika-server-1.26.jar?filename=tika/tika-server-1.26.jar&action=download
Resolving www.apache.org (www.apache.org)... 207.244.88.140, 95.216.26.30, 2a01:4f9:2a:1a61::2
Connecting to www.apache.org (www.apache.org)|207.244.88.140|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://archive.apache.org/dist/tika/tika-server-1.26.jar [following]
--2021-06-08 04:17:01--  https://archive.apache.org/dist/tika/tika-server-1.26.jar
Resolving archive.apache.org (archive.apache.org)... 138.201.131.134, 2a01:4f8:172:2ec5::2
Connecting to archive.apache.org (archive.apache.org)|138.201.131.134|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 79903002 (76M) [application/java-archive]
Saving to: '/tika-server-1.26.jar'

     0K .......... .......... .......... .......... ..........  0%  171K 7m36s
    50K .......... .......... .......... .......... ..........  0%  283K 6m5s
   100K .......... .......... .......... .......... ..........  0%  483K 4m57s
   150K .......... .......... .......... .......... ..........  0%  496K 4m22s

try this:

./docker-tool.sh build 1.26 tika-server tesseract-ocr-fra tesseract-ocr-fas

 ---> 594d05b32156
Step 22/26 : COPY --from=fetch_tika /${TIKA_JAR_NAME}-${TIKA_VERSION}.jar /${TIKA_JAR_NAME}-${TIKA_VERSION}.jar
 ---> 74da0f6e2136
Step 23/26 : USER $UID_GID
 ---> Running in 27cd65503cc4
Removing intermediate container 27cd65503cc4
 ---> 3087a7429f40
Step 24/26 : EXPOSE 9998
 ---> Running in 85d927ba4187
Removing intermediate container 85d927ba4187
 ---> bc6b467c7eed
Step 25/26 : ENTRYPOINT [ "/bin/sh", "-c", "exec java -jar /${TIKA_JAR_NAME}-${TIKA_VERSION}.jar -h 0.0.0.0 $0 $@"]
 ---> Running in 22f85e5b9e83
Removing intermediate container 22f85e5b9e83
 ---> 16c47b78d7e9
Step 26/26 : LABEL maintainer="Apache Tika Developers dev@tika.apache.org"
 ---> Running in d670b34497d3
Removing intermediate container d670b34497d3
 ---> 6f04502585ad
Successfully built 6f04502585ad
Successfully tagged apache/tika:1.26-full

sweb@sweb-laptop:/sweb/tmp/tika-d-mhf$ TZ=UTC date && docker images | grep tika
Tue 08 Jun 2021 04:20:15 AM UTC
apache/tika                             1.26-full         6f04502585ad   2 minutes ago   690MB
apache/tika                             1.26              65ea0073c1e2   7 minutes ago   408MB

feat: set tesseract ocr langauges as docker build args

02ea014

fix: docker-tools.sh

106b0e3

dameikle requested changes Jan 1, 2021

View reviewed changes

docker-tool.sh Outdated Show resolved Hide resolved

docker-tool.sh Outdated Show resolved Hide resolved

docker-tool.sh Outdated Show resolved Hide resolved

fix: pR

5781824

mhf-ir requested a review from dameikle January 1, 2021 22:10

mhf-ir added 2 commits May 24, 2021 13:58

Merge branch 'master' into master

b3e1b75

Update README.md

6a902d6

lewismc requested changes May 26, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

docker-tool.sh Outdated Show resolved Hide resolved

docker-tool.sh Outdated Show resolved Hide resolved

lewismc changed the title ~~set tesseract ocr langauges as docker build args~~ [TIKA-3420] Set tesseract ocr langauges as docker build args May 26, 2021

mhf-ir commented May 26, 2021

View reviewed changes

mhf-ir and others added 6 commits May 26, 2021 22:49

change for solve PR

12cf44e

fix conflict

93ca3e9

Update docker-tool.sh

a18d572

Merge branch 'master' into master

79bdbe6

Merge branch 'master' of github.com:apache/tika-docker

4f703de

Merge branch 'master' of github.com:mhf-ir/tika-docker

d6c3e68

mhf-ir requested a review from lewismc May 31, 2021 06:41

fix: bash args

5ffc62f

mhf-ir added 2 commits June 8, 2021 08:38

fix: test

bcff5c9

fix: no-cache

b0003df

Conversation

mhf-ir commented Dec 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhf-ir commented Dec 15, 2020

Uh oh!

dameikle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mhf-ir commented Jan 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhf-ir commented May 24, 2021

Uh oh!

lewismc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mhf-ir left a comment

Choose a reason for hiding this comment

Uh oh!

mhf-ir commented May 26, 2021

Uh oh!

lewismc commented Jun 5, 2021

Uh oh!

mhf-ir commented Jun 6, 2021

Uh oh!

mhf-ir commented Jun 7, 2021

Uh oh!

lewismc commented Jun 7, 2021

Uh oh!

mhf-ir commented Jun 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mhf-ir commented Dec 15, 2020 •

edited

Loading

mhf-ir commented Jan 1, 2021 •

edited

Loading