fix(frontend): give unit tests timeout headroom for loaded macOS runners - #7717
Merged
mengw15 merged 3 commits intoAug 17, 2026
Merged
Conversation
The macos-latest frontend leg failed 6 times in 3 days, each on a pure timeout in a different spec -- never a failed assertion. The leg's own wall time swings ~2x run to run, and the same test that takes ~400ms on ubuntu has been observed at 11s+ inside a beforeEach on a loaded macOS runner, while Vitest's default limits (5s test / 10s hook) are fixed absolute values that don't scale with runner load. Raise both limits in vitest.config.ts (which previously set neither): testTimeout 20s, hookTimeout 30s -- roughly 4x/3x the worst observed times. A genuinely hung test still fails, just a few seconds later on a 9-17 minute leg, which is strictly cheaper than re-running CI and eroding the signal a red leg carries. The browser-mode config (vitest.browser.config.ts) keeps Vitest's defaults: no timeout failures have been observed on that leg. Closes apache#7713.
Contributor
Backport auto-label reportThis
|
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds timeout headroom to reduce flaky frontend unit tests on loaded macOS runners.
Changes:
- Raises test timeout to 20 seconds.
- Raises hook timeout to 30 seconds.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7717 +/- ##
============================================
- Coverage 90.94% 90.93% -0.01%
Complexity 4452 4452
============================================
Files 1175 1175
Lines 47140 47140
Branches 5284 5284
============================================
- Hits 42870 42869 -1
Misses 2580 2580
- Partials 1690 1691 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Meng Wang <mengw15@uci.edu>
Yicong-Huang
approved these changes
Aug 17, 2026
Yicong-Huang
left a comment
Yicong-Huang
left a comment
Contributor
There was a problem hiding this comment.
🟡 0 must-fix · 1 advisory · 0 polish — implementation is ready; the PR description retains one stale quantitative claim.
Conventions (1)
- Description: replace “roughly 4x/3x the worst observed times” with “4x/3x the defaults” (advisory)
Contributor
aglinxinyuan
added a commit
to aglinxinyuan/texera
that referenced
this pull request
Aug 19, 2026
apache#7717 merged the same jsdom raise on main (`testTimeout: 20000`, `hookTimeout: 30000`) while this branch carried 30s/30s, which is what the conflict was. The merge kept this branch's numbers, so the branch was reverting a value another author had just landed — inside a merge commit, with no argument for the change. Take main's verbatim instead: `frontend/vitest.config.ts` now has no diff against main at all. That leaves this PR scoped to what apache#7717 deliberately left out, and two statements that were true before it landed and are not now: - `vitest.browser.config.ts` justified `testTimeout: 30_000` as "the same 30s the jsdom config uses". jsdom is 20s. The standing argument is that browser mode's 15s default is now the tightest per-test ceiling in the frontend job, on the slower of its two runtimes, on the same macOS runners the jsdom raise was for — so it gets at least as much headroom. `hookTimeout` still stays absent: `browser.enabled` already resolves it to 30s. - `TESTING.md` read "30s per test in both configs" with one shared provenance. Split per config against the post-apache#7717 values: jsdom 20s test / 30s hook from apache#7717, browser 30s test from here, browser hooks left at the resolved default. `.github/workflows/build.yml` is untouched by any of this — the `fail-fast: false` and `timeout-minutes: 30` on the frontend job are the part of apache#6073 that apache#7717 does not cover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
The
build / frontend (macos-latest)leg failed 6 times between 08-14 and 08-17, each time on a pure timeout in a different spec — never a failed assertion (details and per-failure table in #7713). The leg's own wall time swings ~2x run to run (9m17s–16m52s), and the same test that runs in ~400ms on ubuntu has been observed at 11s+ inside abeforeEachon a loaded macOS runner — while Vitest's default limits (5s test / 10s hook) are fixed absolute values that don't scale with runner load. Nothing in the frontend test setup changed in that window; the margin is simply thin enough that ordinary macOS runner variance crosses it.testTimeout: 20000andhookTimeout: 30000infrontend/vitest.config.ts(which previously set neither, inheriting the 5s/10s defaults) — roughly 4x/3x the worst observed times. Both are needed: 4 of the 6 failures hit the test timeout, 2 hit the hook timeout.vitest.browser.config.ts(the browser-mode leg) deliberately keeps the defaults — no timeout failures have been observed there.hub-search-result/searchstand up real child components to work around the coverage-attribution loss in Template coverage does not register for components whose spec calls TestBed.overrideComponent #7458; undoing that would revert test(frontend): render the dashboard search with its real children #7627 / test(frontend): render the hub workflow detail with its real children #7535).Any related issues, documentation, discussions?
Closes #7713.
How was this PR tested?
vitest.config.tsfor the full 202-spec / 4704-test suite.InlineConfigtypings (tsc --noEmitpasses — the option names and types are validated), andprettier --checkpasses, soformat:ciis unaffected.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-opus-4-8)