[SYNCOPE-1942] added getString to retrieve the label from localization properties file #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n properties file
ilgrosso
changed the title
ilgrosso
requested changes
Dec 30, 2025
Member
ilgrosso
left a comment
ilgrosso
left a comment
There was a problem hiding this comment.
Besides what reported above, the same approach should be applied to extPages in the same way
|
|
||
| BookmarkablePageLink<Page> link = new BookmarkablePageLink<>("idmPage", item.getModelObject()); | ||
| link.add(new Label("idmPageLabel", ann.label())); | ||
| link.add(new Label("idmPageLabel", getString(ann.label()))); |
Member
There was a problem hiding this comment.
Use the getString() variant with default, e.g.
getString(ann.label(), null, ann.label())so it will work even when the actual translation is not available
|
|
||
| BookmarkablePageLink<Page> link = new BookmarkablePageLink<>("amPage", item.getModelObject()); | ||
| link.add(new Label("amPageLabel", ann.label())); | ||
| link.add(new Label("amPageLabel", getString(ann.label()))); |
| sessionExpiration.header=Session Expiration | ||
| sessionExpiration.body=Your session is about to expire. Please select the appropriate option to keep working. | ||
| sessionExpiration.extend=Extend | ||
|
|
Member
There was a problem hiding this comment.
These labels shall be provided in the same module where the corresponding page is located, e.g. ``client/idm/console/src/main/resources/...forTopology`
The other two labels are useless and should be removed.
Member
|
@massx1 welcome back! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.