This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-1168. Add database initialization metadata with flyway#873
Open
cdmikechen wants to merge 2 commits intoapache:masterfrom
Open
SUBMARINE-1168. Add database initialization metadata with flyway#873cdmikechen wants to merge 2 commits intoapache:masterfrom
cdmikechen wants to merge 2 commits intoapache:masterfrom
Conversation
cdmikechen
force-pushed
the
SUBMARINE-1168
branch
from
3c35bb6 to
70198cd
Compare
cdmikechen
force-pushed
the
SUBMARINE-1168
branch
from
70198cd to
db64bd9
Compare
Codecov Report
@@ Coverage Diff @@
## master #873 +/- ##
=======================================
Coverage 67.27% 67.27%
=======================================
Files 128 128
Lines 6224 6224
=======================================
Hits 4187 4187
Misses 2037 2037
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add a database initialization metadata service with flyway. When users use their own RDS service or database, submarine can automatically initialize the database.
Since no association usage has been found in the server-core/k8s package, only the submarine database has been initialized for the time being, and metastore and mlflow have not been processed.
What type of PR is it?
Feature
Todos
DatabaseMetadataServiceto init database metadata by flywayWhat is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1168
How should this be tested?
Have added a test case
org.apache.submarine.server.database.TestInitDatabaseMetadataScreenshots (if appropriate)
Questions: