SLING-12217 Cache model implementation class lookups per ResourceResolver#88
Open
joerghoh wants to merge 3 commits into
Open
SLING-12217 Cache model implementation class lookups per ResourceResolver#88joerghoh wants to merge 3 commits into
joerghoh wants to merge 3 commits into
Conversation
joerghoh
commented
Jun 28, 2026
joerghoh
commented
Contributor
- ModelAdapterFactory: cache the resolved ModelClass (or a negative-result sentinel) in the backing ResourceResolver.getPropertyMap(), as a bounded LRU map to avoid unbounded growth
- AdapterImplementations: add requiresImplementationPickerLookup() to limit caching to the picker-based path.
- ModelAdapterFactoryConfiguration: add cache_implementation_lookups (default true) and implementation_lookup_cache_size (default 100).
- add test cases and run relevant existing tests with and without this feature enabled
…lver - ModelAdapterFactory: cache the resolved ModelClass (or a negative-result sentinel) in the backing ResourceResolver.getPropertyMap(), as a bounded LRU map to avoid unbounded growth - AdapterImplementations: add requiresImplementationPickerLookup() to limit caching to the picker-based path. - ModelAdapterFactoryConfiguration: add cache_implementation_lookups (default true) and implementation_lookup_cache_size (default 100). - add test cases and run relevant existing tests with and without this feature enabled
added 2 commits
June 30, 2026 15:03
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.