-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Envoy metrics service receiver: support adapter listener metrics. #13692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds support for Envoy listener metrics to the Envoy metrics service receiver. The implementation follows a similar pattern to the existing cluster metrics adapter by introducing a new ListenerMetricsAdapter class that normalizes listener metric names to envoy_listener_metrics and preserves the original metric name as a label.
Changes:
- Added
ListenerMetricsAdapterclass to adapt Envoy listener metrics - Integrated listener metrics handling into
ProtoMetricFamily2MetricsAdapter - Updated
MetricServiceGRPCHandlerto use the new listener metrics adapter
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/metrics/adapters/ListenerMetricsAdapter.java | New adapter class that normalizes listener metric names and adds metrics_name label |
| oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/metrics/adapters/ProtoMetricFamily2MetricsAdapter.java | Added listener metrics adapter field and routing logic for listener. prefix |
| oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/MetricServiceGRPCHandler.java | Updated to instantiate ListenerMetricsAdapter when creating ProtoMetricFamily2MetricsAdapter |
| oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/test/java/org/apache/skywalking/oap/server/receiver/envoy/ListenerMetricsAdapterTest.java | Test coverage for listener metrics adapter with various metric name patterns |
| oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/test/java/org/apache/skywalking/oap/server/receiver/envoy/ClusterManagerMetricsAdapterTest.java | Added test case for SSL certificate metrics |
| docs/en/changes/changes.md | Updated changelog to document the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CHANGESlog.