Skip to content

Conversation

@wankai123
Copy link
Member

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@wankai123 wankai123 added this to the 10.4.0 milestone Feb 5, 2026
@wankai123 wankai123 requested review from Copilot and wu-sheng February 5, 2026 03:38
@wankai123 wankai123 added backend OAP backend related. enhancement Enhancement on performance or codes labels Feb 5, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for Envoy listener metrics to the Envoy metrics service receiver. The implementation follows a similar pattern to the existing cluster metrics adapter by introducing a new ListenerMetricsAdapter class that normalizes listener metric names to envoy_listener_metrics and preserves the original metric name as a label.

Changes:

  • Added ListenerMetricsAdapter class to adapt Envoy listener metrics
  • Integrated listener metrics handling into ProtoMetricFamily2MetricsAdapter
  • Updated MetricServiceGRPCHandler to use the new listener metrics adapter

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/metrics/adapters/ListenerMetricsAdapter.java New adapter class that normalizes listener metric names and adds metrics_name label
oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/metrics/adapters/ProtoMetricFamily2MetricsAdapter.java Added listener metrics adapter field and routing logic for listener. prefix
oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/MetricServiceGRPCHandler.java Updated to instantiate ListenerMetricsAdapter when creating ProtoMetricFamily2MetricsAdapter
oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/test/java/org/apache/skywalking/oap/server/receiver/envoy/ListenerMetricsAdapterTest.java Test coverage for listener metrics adapter with various metric name patterns
oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/test/java/org/apache/skywalking/oap/server/receiver/envoy/ClusterManagerMetricsAdapterTest.java Added test case for SSL certificate metrics
docs/en/changes/changes.md Updated changelog to document the new feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

wankai123 and others added 3 commits February 5, 2026 11:46
…n/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/metrics/adapters/ListenerMetricsAdapter.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wu-sheng
wu-sheng previously approved these changes Feb 5, 2026
@wankai123 wankai123 merged commit 84e45c5 into apache:master Feb 5, 2026
357 of 360 checks passed
@wankai123 wankai123 deleted the envoy-listener-metrics branch February 5, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. enhancement Enhancement on performance or codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants