This repository was archived by the owner on May 26, 2020. It is now read-only.
SANTUARIO-525 Made Base64 line length and line separator configurable…#19
Open
peterdemaeyer wants to merge 1 commit intoapache:trunkfrom
Open
SANTUARIO-525 Made Base64 line length and line separator configurable…#19peterdemaeyer wants to merge 1 commit intoapache:trunkfrom
peterdemaeyer wants to merge 1 commit intoapache:trunkfrom
Conversation
…, such that "
" in Base64 encoded elements can be avoided
78d4853 to
686a1a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XMLSecurityProperties.XMLUtilsto hold the Base64 parameters per thread. The alternative is to pass them as parameters toXMLUtils.encode, which is what I started doing at first, but it lead to a lot more code changes since the parameters have to be passed everywhere through the whole call stack. The approach with the thread-local seemed like a good alternative, certainly no worse than the configuration with the system property.XMLUtils.ignoreLineBreaksandisIgnoreLineBreaks.ignoreLineBreaksandisIgnoreLineBreaks, because the new mechanism for configuring Base64 parameters is far more flexible. I considered removing those methods, but I decided not to because they're part of the public API of Santuario and it's probably not a good idea to remove them just yet.