[fix][misc][branch-4.2] Pass webServiceTlsCiphers to Jetty factory

[shoemoney]

Fixes silent ignore of TLS cipher and protocol restrictions in the broker WebService and proxy lookup leg.

Motivation

WebService.java:608 passes getTlsCiphers/getTlsProtocols to the Jetty factory, ignoring webServiceTlsCiphers/webServiceTlsProtocols. ProxyConnection.createClientConfiguration omits ciphers/protocols entirely for the broker lookup client. This allows silent bypass of TLS security restrictions configured by operators.

Modifications

• WebService: use firstNonEmpty(getWebServiceTlsCiphers, getTlsCiphers) and same for protocols with fallback, mirroring DefaultBrokerTlsFactory.webPolicy
• ProxyConnection: propagate brokerClientTlsCiphers/brokerClientTlsProtocols to ClientConfigurationData for the lookup leg

Verifying this change

• Make sure that the change passes the CI checks.
• This change is already covered by existing tests (WebService and ProxyConnection).

Does this pull request potentially affect one of the following parts:

• The default values of configurations
• Anything that affects deployment

[lhotari]

Thanks for the PR. There's currently PIP-478 implementation PRs in progress for the master branch which will cover this gap. Please target branch-4.2 with this change (rebase your PR branch on top of origin/branch-4.2 and update the target branch for this PR to apache:branch-4.2).

[shoemoney]

Done, rebased onto branch-4.2 and retargeted the PR (fixed in 62661b3).

[codecov-commenter]

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.88%. Comparing base (dff9973) to head (62661b3).
⚠️ Report is 140 commits behind head on branch-4.2.

Files with missing lines	Patch %	Lines
.../java/org/apache/pulsar/broker/web/WebService.java	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##             branch-4.2   #26423      +/-   ##
================================================
+ Coverage         72.26%   72.88%   +0.61%     
- Complexity         2427    35002   +32575     
================================================
  Files              1963     1970       +7     
  Lines            156135   157094     +959     
  Branches          17896    18061     +165     
================================================
+ Hits             112838   114502    +1664     
+ Misses            34151    33370     -781     
- Partials           9146     9222      +76     

Flag	Coverage Δ
inttests	25.74% <80.00%> (+0.02%)	⬆️
systests	22.33% <0.00%> (-0.09%)	⬇️
unittests	73.96% <80.00%> (+0.71%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...rg/apache/pulsar/proxy/server/ProxyConnection.java	57.69% <100.00%> (-0.49%)	⬇️
.../java/org/apache/pulsar/broker/web/WebService.java	89.89% <66.66%> (-0.30%)	⬇️

... and 156 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.