Skip to content

fix: run alignAcknowledgeStatus for every flushed entry, not just the last one #26305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: run alignAcknowledgeStatus for every flushed entry, not just the last one #26305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2462,10 +2462,20 @@ public void operationComplete() {
mdEntry.newPosition, null);

// Remove from the individual deleted messages all the entries before the new mark delete
// point.
// point. When several mark-delete requests where flushed together (callbackGroup), apply
// the in-memory state mutation of EVERY request in the group, not just the last one.
// Otherwise a cursor reset that was queued before a later ack would have its
// alignAcknowledgeStatusAfterPersisted silently dropped while the reset still reports
// success, leaving the cursor un-moved (see issue #26304).
lock.writeLock().lock();
try {
mdEntry.alignAcknowledgeStatus();
if (mdEntry.callbackGroup != null) {
for (MarkDeleteEntry e : mdEntry.callbackGroup) {
e.alignAcknowledgeStatus();
}
} else {
mdEntry.alignAcknowledgeStatus();
}
} finally {
lock.writeLock().unlock();
}
Expand Down
Loading