Skip to content

[fix] [test] Fix flaky test testPerTopicExpiredStat - #22018

Merged
Technoboy- merged 1 commit into
apache:masterfrom
315157973:flaky-test
Feb 4, 2024
Merged

[fix] [test] Fix flaky test testPerTopicExpiredStat#22018
Technoboy- merged 1 commit into
apache:masterfrom
315157973:flaky-test

Conversation

@315157973

@315157973 315157973 commented Feb 4, 2024

Copy link
Copy Markdown
Contributor

Motivation

Large floats may fail to convert because of commas in the string
image

Modifications

Change to BigDecimal

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@Technoboy- Technoboy- added this to the 3.3.0 milestone Feb 4, 2024
@Technoboy- Technoboy- changed the title [fix] [test] fix flaky test testPerTopicExpiredStat [fix] [test] Fix flaky test testPerTopicExpiredStat Feb 4, 2024
@codecov-commenter

codecov-commenter commented Feb 4, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.64%. Comparing base (e7c2a75) to head (5706f86).
⚠️ Report is 1799 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22018      +/-   ##
============================================
- Coverage     73.73%   73.64%   -0.09%     
+ Complexity    32536    32497      -39     
============================================
  Files          1863     1863              
  Lines        138816   138816              
  Branches      15217    15217              
============================================
- Hits         102356   102233     -123     
- Misses        28589    28696     +107     
- Partials       7871     7887      +16     
Flag Coverage Δ
inttests 24.09% <ø> (-0.14%) ⬇️
systests 23.91% <ø> (-0.16%) ⬇️
unittests 72.91% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 59 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Technoboy-
Technoboy- merged commit 5dfdcb7 into apache:master Feb 4, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants