[wip][feat][io] Debezium DB2 source connector for Pulsar - #19821
[wip][feat][io] Debezium DB2 source connector for Pulsar#19821devinbost wants to merge 45 commits into
Conversation
|
@devinbost Please add the following content to your PR description and select a checkbox: |
nicoloboschi
left a comment
There was a problem hiding this comment.
LGTM, just one comment
@dlg99 PTAL
dlg99
left a comment
There was a problem hiding this comment.
Great job!
LGTM with couple of nits + needs proper PR description and title
|
Please follow up with docs update https://github.com/apache/pulsar-site/blob/main/docs/io-debezium-source.md |
|
Hi @devinbost, I see you've contributed docs along with code changes, thank you! A gentle reminder: have you submitted a PIP for this change? Can you attach the PIP vote link in the PR description? |
…zium/db2/package-info.java Changed oracle to db2 Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
Hi @Anonymitaet , I don't think a PIP is typically required for new connectors. |
|
I don't think that a PIP is required for a new Connector. PIP are important for new APIs and for API changes/breaking changes. Add a new Connector has very little impact, especially for this kind of connectors (based on Debezium) |
|
I am generally +1 on this work, but I left a comment about the tests |
|
The pr had no activity for 30 days, mark with Stale label. |
|
cc @devinbost @eolivelli do we still make progress on this PR? |
|
It's very close to being finished but I just haven't had time to finish it.
There's just a test that needs to pass. IIRC there was a mismatch in the
number of records the connector was emitting and the number expected due to
something being emitted twice.
…--
Devin Bost
Sent from mobile
On Mon, Jun 12, 2023, 7:57 PM tison ***@***.***> wrote:
cc @devinbost <https://github.com/devinbost> @eolivelli
<https://github.com/eolivelli> do we still make progress on this PR?
—
Reply to this email directly, view it on GitHub
<#19821 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABYTBL3MUEGT24YKV3RYSODXK63H5ANCNFSM6AAAAAAV3VRUT4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
The pr had no activity for 30 days, mark with Stale label. |
|
@devinbost @eolivelli It looks like this is close, but now there are CI and TestContainer updates needed. |
|
The pr had no activity for 30 days, mark with Stale label. |
Adds new Debezium DB2 source connector to pulsar-io and includes integration tests.
Fixes #7837
Motivation:
Getting data from IBM DB2 into Pulsar
docdoc-requireddoc-not-neededdoc-completeDocs at apache/pulsar-site#494
Does this pull request potentially affect one of the following parts:
Dependencies (add or upgrade a dependency)The public APIThe schemaThe default values of configurationsThe threading modelThe binary protocolThe REST endpointsThe admin CLI optionsThe metricsAnything that affects deploymentBuild processThe biggest change was that we needed to include building a Docker image in the build process for testing the DB2 connector since Debezium hasn't published an actual image with the necessary files. I verified that the DB2 license permits use of these drivers for testing purposes. More details in comments below (#19821 (comment) and #19821 (comment)).
The new Dockerfile was added to
tests/docker-images/debezium-db2-test-imageand was scoped as part of theintegrationTestsprofile.Tested against DB2 v11.5
Matching PR in forked repository
devinbost#15