Skip to content

[wip][feat][io] Debezium DB2 source connector for Pulsar - #19821

Open
devinbost wants to merge 45 commits into
apache:masterfrom
devinbost:db2
Open

[wip][feat][io] Debezium DB2 source connector for Pulsar#19821
devinbost wants to merge 45 commits into
apache:masterfrom
devinbost:db2

Conversation

@devinbost

@devinbost devinbost commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Adds new Debezium DB2 source connector to pulsar-io and includes integration tests.
Fixes #7837

Motivation:
Getting data from IBM DB2 into Pulsar

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Docs at apache/pulsar-site#494

Does this pull request potentially affect one of the following parts:

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment
  • Build process

The biggest change was that we needed to include building a Docker image in the build process for testing the DB2 connector since Debezium hasn't published an actual image with the necessary files. I verified that the DB2 license permits use of these drivers for testing purposes. More details in comments below (#19821 (comment) and #19821 (comment)).

The new Dockerfile was added to tests/docker-images/debezium-db2-test-image and was scoped as part of the integrationTests profile.

Tested against DB2 v11.5

Matching PR in forked repository
devinbost#15

@github-actions

Copy link
Copy Markdown

@devinbost Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@devinbost devinbost changed the title Added Debezium DB2 connector for Pulsar [WIP] Added Debezium DB2 connector for Pulsar Mar 17, 2023

@nicoloboschi nicoloboschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment

@dlg99 PTAL

@dlg99 dlg99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
LGTM with couple of nits + needs proper PR description and title

@dlg99

dlg99 commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

Please follow up with docs update https://github.com/apache/pulsar-site/blob/main/docs/io-debezium-source.md

@devinbost devinbost changed the title [WIP] Added Debezium DB2 connector for Pulsar Added Debezium DB2 connector for Pulsar Mar 28, 2023
@devinbost devinbost changed the title Added Debezium DB2 connector for Pulsar [feat][io] Debezium DB2 source connector for Pulsar Mar 28, 2023
@github-actions github-actions Bot added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-label-missing labels Mar 28, 2023
@devinbost
devinbost requested a review from nicoloboschi March 28, 2023 20:30
@Anonymitaet

Copy link
Copy Markdown
Member

Hi @devinbost, I see you've contributed docs along with code changes, thank you!

A gentle reminder: have you submitted a PIP for this change? Can you attach the PIP vote link in the PR description?

…zium/db2/package-info.java


Changed oracle to db2

Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
@devinbost

Copy link
Copy Markdown
Contributor Author

A gentle reminder: have you submitted a PIP for this change? Can you attach the PIP vote link in the PR description?

Hi @Anonymitaet , I don't think a PIP is typically required for new connectors.

Comment thread tests/docker-images/latest-version-image/Dockerfile Outdated
@eolivelli

eolivelli commented Mar 30, 2023

Copy link
Copy Markdown
Contributor

I don't think that a PIP is required for a new Connector.

PIP are important for new APIs and for API changes/breaking changes.

Add a new Connector has very little impact, especially for this kind of connectors (based on Debezium)

@eolivelli

Copy link
Copy Markdown
Contributor

I am generally +1 on this work, but I left a comment about the tests

@github-actions

Copy link
Copy Markdown

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions Bot added the Stale label May 15, 2023
@tisonkun

Copy link
Copy Markdown
Member

cc @devinbost @eolivelli do we still make progress on this PR?

@github-actions github-actions Bot removed the Stale label Jun 13, 2023
@devinbost

devinbost commented Jun 13, 2023 via email

Copy link
Copy Markdown
Contributor Author

@github-actions

Copy link
Copy Markdown

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions Bot added the Stale label Jul 14, 2023
@dave2wave

Copy link
Copy Markdown
Member

@devinbost @eolivelli It looks like this is close, but now there are CI and TestContainer updates needed.

@github-actions github-actions Bot removed the Stale label Jul 17, 2023
@Technoboy- Technoboy- added this to the 3.2.0 milestone Jul 31, 2023
@github-actions

Copy link
Copy Markdown

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions Bot added the Stale label Aug 31, 2023
@Technoboy- Technoboy- modified the milestones: 3.2.0, 3.3.0 Dec 22, 2023
@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@lhotari lhotari modified the milestones: 4.0.0, 4.1.0 Oct 14, 2024
@lhotari lhotari removed this from the 4.1.0 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-complete Your PR changes impact docs and the related docs have been already added. ready-to-test Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DB2 Connector for Pulsar

10 participants