Remove Pulsar Manager support from the chart - #718
Open
lhotari wants to merge 1 commit into
Open
Conversation
Pulsar Manager has been poorly maintained for a long time. Drop the component from the chart and fail fast with a migration message when it is still enabled so that the removal is explicit instead of silently dropping deployed resources. Removed: - the pulsar-manager StatefulSet, Services, ConfigMap, Ingress, admin Secret and the pulsar-manager-init Job templates - the `pulsar_manager` values section, `images.pulsar_manager`, `components.pulsar_manager` and the `auth.superUsers.manager` role - the Pulsar Manager CI job, values files and helm.sh test function Added `pulsar-manager-removed-validation.yaml`, which fails the render when `components.pulsar_manager` is truthy and points users at Dekaf, the supported web UI in this chart. README.md documents the removal under "Upgrading to Helm chart version 4.8.0", including that the `components.pulsar_manager` key must be removed or set to false before upgrading, and how to migrate to Dekaf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Apache Pulsar Manager has been poorly maintained for a long
time — the chart has shipped a warning recommending the Dekaf UI instead for several releases, and the
bundled image is still
apachepulsar/pulsar-manager:v0.4.0. Keeping the component in the chart meansmaintaining ~600 lines of templates, a dedicated CI cluster job and an extra superuser role for software
that is effectively unmaintained.
This PR drops Pulsar Manager support completely. Dekaf
(
components.dekaf: true) is the supported web UI in this chart and the recommended alternative.Modifications
Chart
Deleted
pulsar-manager-statefulset.yaml,pulsar-manager-service.yaml,pulsar-manager-configmap.yaml,pulsar-manager-ingress.yaml,pulsar-manager-admin-secret.yamlandpulsar-manager-cluster-initialize.yaml.Added
pulsar-manager-removed-validation.yaml, which fails the render whencomponents.pulsar_manageris truthy so that the removal is explicit rather than silently dropping deployed resources. It follows
the existing
broker-package-storage-validation.yamlpattern (a rendered template, not a_-prefixedpartial, so the
failis actually executed) and names the keys to remove plus the Dekaf alternative:values.yaml: removedcomponents.pulsar_manager,images.pulsar_manager,auth.superUsers.managerand the whole
pulsar_manager:section.Docs
README.md: removed the Pulsar Manager feature bullet and section; the Dekaf UI section now states it isthe supported web UI and the migration target; new
## Upgrading to Helm chart version 4.8.0→### Pulsar Manager support has been removedsection explains the fail-fast error, that thecomponents.pulsar_managerkey must be removed or set tofalseto allow the upgrade, which other stalekeys to drop, the PVC backup caveat, and how to enable Dekaf.
examples/README.mdand the example values files no longer mention the component.CI
Pulsar Managercluster matrix job and.ci/clusters/values-pulsar-manager.yaml,ci::test_pulsar_managerfrom.ci/helm.shand its call site in.ci/chart_test.sh, the--set components.pulsar_manager=truekubeconform flag, and the manager blocks in.ci/templates-all-values*.yaml,.ci/kustomization.yaml,.ci/values-common.yamland the clustervalues files.
Note:
Chart.yamlis still at the released4.7.0since this repo bumps the version in the releasecommit. The README section is written for the next minor,
4.8.0— it needs adjusting if the next releasenumber differs.
Verifying this change
helm lint charts/pulsarpasses.helm templaterenders cleanly for the default values, all.ci/clusters/*.yaml(with.ci/values-common.yaml), allexamples/*.yaml, and.ci/templates-all-values.yamlwith and withouttemplates-all-values-patch1.yaml.--set components.pulsar_manager=truefails with the message above.pulsar_manager:/images.pulsar_manager/auth.superUsers.managerkeys butcomponents.pulsar_manager: falserenders fine, so upgrading onlyrequires removing or disabling the component flag.
superUserRolesno longer contains the manager role.