Consolidate PolarisStorageConfigurationInfo retrieval#5030
Merged
Conversation
Removes `FileIOUtil` and `BaseMetaStoreManager.extractStorageConfiguration`, moving their logic into `PolarisStorageConfigurationInfo` where it naturally belongs. Renames `findStorageInfoFromHierarchy` to `findEntityWithStorageConfigFromHierarchy` for clarity, and adds `findStorageConfigFromHierarchy` to return the deserialized config directly.
XN137
force-pushed
the
consolidate-storage-config-helpers
branch
from
July 10, 2026 15:16
323c89b to
a19bfcd
Compare
XN137
marked this pull request as ready for review
July 10, 2026 15:48
github-project-automation
Bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
nandorKollar
approved these changes
Jul 13, 2026
Contributor
|
Merging after > 3 days in review and multiple approvals. If there are follow-up concerns let's address them in separate PRs. |
github-project-automation
Bot
moved this from Ready to merge
to Done
in Basic Kanban Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
FileIOUtilandBaseMetaStoreManager.extractStorageConfiguration, moving their logic intoPolarisStorageConfigurationInfowhere it naturally belongs. RenamesfindStorageInfoFromHierarchytofindEntityWithStorageConfigFromHierarchyfor clarity, and addsfindStorageConfigFromHierarchyto return the deserialized config directly.