fix(jdbc): skip slash-only prefixes in optimized overlap queries#5029
Open
vigneshio wants to merge 1 commit into
Open
fix(jdbc): skip slash-only prefixes in optimized overlap queries#5029vigneshio wants to merge 1 commit into
vigneshio wants to merge 1 commit into
Conversation
Scheme stripping turns s3://bucket/path into //bucket/path, so the prefix walk previously emitted / and // equality terms that are not real storage locations. Skip slash-only prefixes when building the overlap query. Same for file:/// paths that produced /// alone. Fixes apache#5023
dimas-b
reviewed
Jul 10, 2026
| for (String component : components) { | ||
| pathBuilder.append(component).append("/"); | ||
| String prefix = pathBuilder.toString(); | ||
| // Skip "/", "//", "///", ... produced from empty path segments around the scheme separator. |
Contributor
There was a problem hiding this comment.
The /// prefix is probably valid. It's the root dir in file: URIs, right?
flyingImer
reviewed
Jul 16, 2026
| } | ||
|
|
||
| @Test | ||
| void generateOverlapQueryDoesNotEmitSlashOnlyPrefixes() { |
Collaborator
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5023.
Follow-up from the side note on #5003.
When building JDBC optimized location-overlap queries, scheme stripping turns paths like
s3://bucket/tmp/locationinto//bucket/tmp/location. The prefix walk then emitted slash-only terms (/,//) that are not real storage locations.