test: wait for async refresh events in testEventsAreEmitted#5022
Merged
Conversation
Fixes flaky LocalIcebergCatalogRelationalTest.testEventsAreEmitted where AFTER_REFRESH_TABLE was asserted before Vert.x event-bus delivery completed. - Clear the test listener after setup so only property-commit refresh events are observed - Await BEFORE/AFTER refresh events via Awaitility (same async path as production PolarisServiceBusEventDispatcher) - Mirror the wait for view refresh events - Add TestPolarisEventListener.hasEvent for await conditions Fixes apache#5019
dimas-b
approved these changes
Jul 9, 2026
dimas-b
left a comment
dimas-b
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the quick fix, @vigneshio !
github-project-automation
Bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
dimas-b
enabled auto-merge (squash)
July 9, 2026 20:40
github-project-automation
Bot
moved this from Ready to merge
to Done
in Basic Kanban Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5019.
LocalIcebergCatalogRelationalTest.testEventsAreEmittedwas flaking with:Refresh events are published over the Vert.x event bus and delivered on a listener executor, so they can land after the test already called
getLatest. That race showed up in CI (including on #5003).