Support Runtime JDBC Driver Loading and Dynamic Datasource Creation#4984
Draft
flyrain wants to merge 3 commits into
Draft
Support Runtime JDBC Driver Loading and Dynamic Datasource Creation#4984flyrain wants to merge 3 commits into
flyrain wants to merge 3 commits into
Conversation
Allow the relational JDBC backend to create and own a Hikari datasource from polaris.persistence.relational.jdbc.* settings when jdbc-url is provided, while preserving the existing Quarkus datasource fallback when it is absent. Cover the new path with unit and integration tests for managed datasource creation, independent datasource creation from separate configs, CockroachDB configuration, production-readiness checks, and loading a JDBC driver from a runtime-provided jar. Document the managed datasource properties and update distribution license metadata for the added runtime dependencies.
flyrain
changed the title
6 tasks
dimas-b
reviewed
Jul 6, 2026
| DatasourceOperations( | ||
| DataSource datasource, | ||
| RelationalJdbcConfiguration relationalJdbcConfiguration, | ||
| boolean closeDataSourceOnClose) { |
Contributor
There was a problem hiding this comment.
closeDataSourceOnClose is awkward to read. How about assumeDataSourceOwnership?
| } | ||
|
|
||
| @Override | ||
| public void close() { |
Contributor
There was a problem hiding this comment.
When is this close() method called?
|
|
||
| We have 2 options for configuring the persistence backend: | ||
| Polaris can use either a Quarkus-managed datasource or a Polaris-managed JDBC connection pool. When | ||
| `polaris.persistence.relational.jdbc.jdbc-url` is set, Polaris creates the JDBC pool directly; |
Contributor
There was a problem hiding this comment.
The only advantage of doing this, that I can see, realizes when Polaris is able to load the JDBC driver dynamically. However, I could not find any provisions for dynamic loading in this PR. Did I miss that? 🤔
If repackaging at the binary level is assumed, a Quakus build can be performed at that stage to make the DataSource available via Quarkus-backed CDI.
dimas-b
reviewed
Jul 6, 2026
| @Override | ||
| public void init(Map<String, String> initArgs) { | ||
| initScript = initArgs.get(INIT_SCRIPT); | ||
| polarisManagedDatasource = Boolean.parseBoolean(initArgs.get(POLARIS_MANAGED_DATASOURCE)); |
Contributor
There was a problem hiding this comment.
Who controls the value of this variable?
Support loading third-party JDBC driver jars from a configured driver directory when Polaris creates the relational JDBC datasource directly. For binary distributions, include visible server and admin jdbc-drivers directories and document the drop-in workflow. Add tests for explicit driver-directory loading and the default quarkus-run.jar sibling directory layout.
Move Polaris-managed JDBC datasource property descriptions into the Quarkus config mapping so generated config docs stay current. Regenerate the relational JDBC config section with copyConfigSectionsToSite.
rmannibucau
reviewed
Jul 7, 2026
| boolean success = false; | ||
| try { | ||
| Thread.currentThread().setContextClassLoader(driverClassLoader); | ||
| HikariDataSource dataSource = |
Contributor
There was a problem hiding this comment.
don't you want to override closeto call closeDriverClassLoader to avoid to leak the driver JarFile?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to support two related requirements:
You can find the test cases for these two requirements in file
JdbcDataSourceFactoryTest.javaChecklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)