Repository navigation
Add regression tests for %{BRANCH} interpolation in Postgres and BigQuery importers - #182
Merged
Merged
Conversation
…uery importers
The %{BRANCH} placeholder handling introduced in apache#124 only had error-path
coverage: tests verified that a query containing %{BRANCH} fails when
--branch is not specified, but nothing asserted the happy path.
Add unit tests asserting the exact query rewrite and parameters for both
SQL-backed importers:
- PostgreSQL: %{BRANCH} is replaced with %s placeholders, one query
parameter per occurrence, and the resulting Series carries the
selected branch name.
- BigQuery: %{BRANCH} is replaced with the @Branch named parameter,
passed as a single STRING ScalarQueryParameter.
- A query without %{BRANCH} is executed with no parameters.
Related to apache#34
Signed-off-by: Aditya Pathak <68177924+Phoenix1504e@users.noreply.github.com>
Gerrrr
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add unit tests for the
%{BRANCH}placeholder interpolation in thePostgreSQL and BigQuery importers (tests only — no production code
changes).
Why
The interpolation handling introduced in #124 only had error-path
coverage: the suite verified that a query containing
%{BRANCH}failswhen
--branchis not specified, but nothing asserted the happy path —the exact query rewrite and the parameters actually passed to the
driver.
This closes the coverage gap I identified while working through #34.
What is tested
%{BRANCH}is replaced with%splaceholders, onequery parameter per occurrence, and the resulting
Seriescarriesthe selected branch name.
parameters.
%{BRANCH}is replaced with the@branchnamedparameter, passed as a single
STRINGScalarQueryParameter.Testing
pytest tests/importer_test.py— 29 passed (4 new)pytest tests/ -k "not e2e"— 227 passed (10 e2e tests need Docker,unchanged)
ruff check,flake8,isort --check-only,autoflake --check—all clean
Closes #34