Repository navigation
Fix --config-file parser broken by configargparse 1.7.3 - #138
Merged
Merged
Conversation
configargparse 1.7.3 changed how env var args are inserted into the arg list, causing `OTAVA_CONFIG` env var expansion to land after the subcommand positional arg. The subparser then rejects `--config-file` as unrecognized. The fix is to add `--config-file` to the parent subparser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes broken CI on master. configargparse 1.7.3 changed how env var args are inserted into the arg list, causing
OTAVA_CONFIGenv var expansion to land after the subcommand positional arg. The subparser then rejects--config-fileas unrecognized.The fix is to add
--config-fileto the parent subparser.These changes in e2e tests look annoying, but they did catch a real bug on master.