Repository navigation
Add e2e Graphite test - #106
Merged
Merged
Conversation
henrikingo
requested changes
Dec 7, 2025
| ) | ||
| container_id = proc.stdout.strip() | ||
|
|
||
| # Determine the randomly assigned host port for 80/tcp (HTTP) |
Contributor
There was a problem hiding this comment.
Maybe helpful to be a bit more specific as the following lines mix python, bash and some docker syntax I never saw before.Like...
Determine the host port docker randomly chose for HTTP. (Maps to 80/tcp inside the container.)
| # Wait for data to be written and available | ||
| time.sleep(5) | ||
|
|
||
| yield http_port |
Contributor
There was a problem hiding this comment.
The postgresql version of this yields also the container ID. It bothers me that these are essentially the same function yet they are inconsistent with their return/yield values. Second, why isn't the carbon port returned?
| assert "+300.0%" in output # cpu_usage change | ||
|
|
||
|
|
||
| @contextmanager |
Contributor
There was a problem hiding this comment.
I feel like there's enough overlap that we should have one function that does this for Postgres, Graphite, etc. Or a common parent class.
Gerrrr
force-pushed
the
e2e-graphite-test
branch
4 times, most recently
from
December 10, 2025 05:46
44f75d8 to
7614495
Compare
Gerrrr
force-pushed
the
e2e-graphite-test
branch
from
December 10, 2025 05:54
7614495 to
87e7c24
Compare
henrikingo
approved these changes
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.