Skip to content

Address feedback from 0.7.0-rc3 - #104

Merged
Gerrrr merged 10 commits into
0.7from
fixup-0.7.0-rc3
Nov 28, 2025
Merged

Address feedback from 0.7.0-rc3#104
Gerrrr merged 10 commits into
0.7from
fixup-0.7.0-rc3

Conversation

@Gerrrr

@Gerrrr Gerrrr commented Nov 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR aims to fix identified issues in 0.7.0-rc3 by:

  1. Reverting OTAVA-82: use ConfigArgParse to create Config #86, Fix config parsing #91, and parts of Fix multiple issues discovered via running examples #95 aiming to fix config parsing.
  2. Fixing otava --help should not look up or validate current config #65 in a more isolated way.

For extra measure, this PR also fixes CLI description (ea2534b) and bundles #103 to have better test coverage.

@Gerrrr
Gerrrr marked this pull request as draft November 28, 2025 05:54
@Gerrrr
Gerrrr force-pushed the fixup-0.7.0-rc3 branch 2 times, most recently from 4de98d6 to d9faf01 Compare November 28, 2025 06:09
@Gerrrr
Gerrrr marked this pull request as ready for review November 28, 2025 06:26
henrikingo
henrikingo approved these changes Nov 28, 2025
View reviewed changes

@henrikingo henrikingo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding e2e tests. Those ought to be valuable as we move forward with CLI changes.

@Gerrrr
Gerrrr merged commit 3021151 into 0.7 Nov 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrikingo henrikingo henrikingo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gerrrr @henrikingo