Skip to content

Conversation

@wangchen61698
Copy link
Contributor

@wangchen61698 wangchen61698 commented Dec 22, 2025

Note: Please adhere to Contributing Guidelines.

Summary

Modify check condition from IFF_UP to IFF_RUNNING in the network sending process

Impact

network sending process

Testing

log info
image

before patch
image

after patch
wlan0 is running status

image image

wlan0 is up status

image

@github-actions github-actions bot added Area: Networking Effects networking subsystem Size: S The size of the change in this PR is small labels Dec 22, 2025
@wangchen61698 wangchen61698 force-pushed the 41977 branch 2 times, most recently from 20698b4 to 2d6df93 Compare December 22, 2025 08:04
Copy link
Contributor

@acassis acassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangchen61698 please provide more details why this modification was necessary. You just said you modified it, but you didn't say why? What was the issue you were solving? Please also provide valid testing showing the issue and showing it was fixed

@jerpelea jerpelea changed the title Modify check condition from IFF_UP to IFF_RUNNING in the network sending process net: update check condition from IFF_UP to IFF_RUNNING in the network sending process Dec 22, 2025
jerpelea
jerpelea previously approved these changes Dec 22, 2025
…process

Modify check condition from IFF_UP  to IFF_RUNNING in the sending process

Signed-off-by: wangchen <wangchen41@xiaomi.com>
@wangchen61698
Copy link
Contributor Author

wangchen61698 commented Jan 9, 2026

@wangchen61698 please provide more details why this modification was necessary. You just said you modified it, but you didn't say why? What was the issue you were solving? Please also provide valid testing showing the issue and showing it was fixed

The issue we encountered is that the network card is in a non-running state but is up. Messages should not be sent out, but the Address Conflict Detection (ACD) function still sends ARP messages. This behavior is incorrect, so we modified the judgment condition. ARP messages can only be sent if the network card is in a running state; otherwise, they cannot be sent. We also simultaneously modified the relevant judgment logic in other business codes to ensure consistency in the judgment of network card status across other businesses @acassis please review it again,Thanks.

@wangchen61698 wangchen61698 marked this pull request as ready for review January 9, 2026 11:13
@xiaoxiang781216 xiaoxiang781216 merged commit 96fcc8b into apache:master Jan 9, 2026
50 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Networking Effects networking subsystem Size: S The size of the change in this PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants