nimble/host/att: Fix handle validation for Read Mult Var Req#2258
Open
piotrnarajowski wants to merge 1 commit into
Open
nimble/host/att: Fix handle validation for Read Mult Var Req#2258piotrnarajowski wants to merge 1 commit into
piotrnarajowski wants to merge 1 commit into
Conversation
If one of the requested characteristic values filled the MTU, this caused the while loop to exit early. As a result, we skipped checking remaining handles and incorrectly retuned a succesful response even when the remaining handles were invalid. -Move MTU check from while loop into the loop body to enforce validation on all requested handles. -validate all requested handles event after MTU fills up Fixes qualification test case GATT/SR/GAR/BI-38-C.
Contributor
Author
|
#AutoPTS run mynewt GATT/SR |
|
Scheduled PR #2258 (comment), board: nrf52, estimated start time: 17:23:16, test case count: 90, estimated duration: 1:29:32 Test cases to be runGATT/SR/GAC/BV-01-CGATT/SR/GAC/BI-01-C GATT/SR/GAD/BV-01-C GATT/SR/GAD/BV-02-C GATT/SR/GAD/BV-03-C GATT/SR/GAD/BV-04-C GATT/SR/GAD/BV-05-C GATT/SR/GAD/BV-06-C GATT/SR/GAR/BV-01-C GATT/SR/GAR/BI-01-C GATT/SR/GAR/BI-02-C GATT/SR/GAR/BI-03-C GATT/SR/GAR/BI-04-C GATT/SR/GAR/BI-05-C GATT/SR/GAR/BV-03-C GATT/SR/GAR/BI-06-C GATT/SR/GAR/BI-07-C GATT/SR/GAR/BI-08-C GATT/SR/GAR/BI-09-C GATT/SR/GAR/BI-10-C GATT/SR/GAR/BI-11-C GATT/SR/GAR/BV-04-C GATT/SR/GAR/BI-12-C GATT/SR/GAR/BI-13-C GATT/SR/GAR/BI-14-C GATT/SR/GAR/BI-15-C GATT/SR/GAR/BI-16-C GATT/SR/GAR/BI-17-C GATT/SR/GAR/BV-05-C GATT/SR/GAR/BI-18-C GATT/SR/GAR/BI-19-C GATT/SR/GAR/BI-20-C GATT/SR/GAR/BI-21-C GATT/SR/GAR/BI-22-C GATT/SR/GAR/BV-06-C GATT/SR/GAR/BV-07-C GATT/SR/GAR/BV-08-C GATT/SR/GAR/BV-09-C GATT/SR/GAR/BV-11-C GATT/SR/GAR/BV-12-C GATT/SR/GAR/BI-36-C GATT/SR/GAR/BI-38-C GATT/SR/GAR/BI-40-C GATT/SR/GAR/BI-42-C GATT/SR/GAR/BI-44-C GATT/SR/GAR/BI-45-C GATT/SR/GAW/BV-01-C GATT/SR/GAW/BV-03-C GATT/SR/GAW/BI-02-C GATT/SR/GAW/BI-03-C GATT/SR/GAW/BI-04-C GATT/SR/GAW/BI-05-C GATT/SR/GAW/BI-06-C GATT/SR/GAW/BV-05-C GATT/SR/GAW/BI-07-C GATT/SR/GAW/BI-08-C GATT/SR/GAW/BI-09-C GATT/SR/GAW/BI-11-C GATT/SR/GAW/BI-12-C GATT/SR/GAW/BI-13-C GATT/SR/GAW/BV-06-C GATT/SR/GAW/BV-10-C GATT/SR/GAW/BV-11-C GATT/SR/GAW/BV-07-C GATT/SR/GAW/BV-08-C GATT/SR/GAW/BV-09-C GATT/SR/GAW/BI-32-C GATT/SR/GAW/BI-33-C GATT/SR/GAW/BI-39-C GATT/SR/GAW/BV-12-C GATT/SR/GAW/BV-13-C GATT/SR/GAW/BV-14-C GATT/SR/GAW/BI-41-C GATT/SR/GAN/BV-01-C GATT/SR/GAN/BV-03-C GATT/SR/GAN/BV-02-C GATT/SR/GAI/BV-01-C GATT/SR/GAI/BV-02-C GATT/SR/GAS/BV-01-C GATT/SR/GAS/BV-02-C GATT/SR/GAS/BV-03-C GATT/SR/GAS/BV-04-C GATT/SR/GAS/BV-05-C GATT/SR/GAS/BV-06-C GATT/SR/GAS/BV-07-C GATT/SR/GAS/BV-08-C GATT/SR/GAT/BV-01-C GATT/SR/UNS/BI-01-C GATT/SR/UNS/BI-02-C GATT/SR/GPM/BV-05-C |
|
AutoPTS Bot results: Failed tests (13)GATT GATT/SR/GAN/BV-02-C RUNNINGGATT GATT/SR/GAR/BV-12-C INDCSV - ERRATA https://github.com//issues/2002 GATT GATT/SR/GAS/BV-02-C FAIL GATT GATT/SR/GAS/BV-04-C FAIL GATT GATT/SR/GAS/BV-05-C FAIL GATT GATT/SR/GAS/BV-06-C FAIL GATT GATT/SR/GAS/BV-07-C FAIL GATT GATT/SR/GAS/BV-08-C INDCSV GATT GATT/SR/GAW/BI-11-C FAIL GATT GATT/SR/GAW/BI-41-C BTP ERROR GATT GATT/SR/GAW/BV-12-C INDCSV - ERRATA https://github.com//issues/2002 GATT GATT/SR/GAW/BV-13-C INDCSV - ERRATA https://github.com//issues/2002 GATT GATT/SR/GAW/BV-14-C INDCSV - ERRATA https://github.com//issues/2002 Successful tests (77)GATT GATT/SR/GAC/BI-01-C PASSGATT GATT/SR/GAC/BV-01-C PASS GATT GATT/SR/GAD/BV-01-C PASS GATT GATT/SR/GAD/BV-02-C PASS GATT GATT/SR/GAD/BV-03-C PASS GATT GATT/SR/GAD/BV-04-C PASS GATT GATT/SR/GAD/BV-05-C PASS GATT GATT/SR/GAD/BV-06-C PASS GATT GATT/SR/GAI/BV-01-C PASS - ERRATA ES-27410 GATT GATT/SR/GAI/BV-02-C PASS GATT GATT/SR/GAN/BV-01-C PASS - ERRATA ES-27410 GATT GATT/SR/GAN/BV-03-C PASS - ERRATA Request ID 172623 GATT GATT/SR/GAR/BI-01-C PASS GATT GATT/SR/GAR/BI-02-C PASS GATT GATT/SR/GAR/BI-03-C PASS GATT GATT/SR/GAR/BI-04-C PASS GATT GATT/SR/GAR/BI-05-C PASS GATT GATT/SR/GAR/BI-06-C PASS GATT GATT/SR/GAR/BI-07-C PASS GATT GATT/SR/GAR/BI-08-C PASS GATT GATT/SR/GAR/BI-09-C PASS GATT GATT/SR/GAR/BI-10-C PASS GATT GATT/SR/GAR/BI-11-C PASS GATT GATT/SR/GAR/BI-12-C PASS GATT GATT/SR/GAR/BI-13-C PASS GATT GATT/SR/GAR/BI-14-C PASS GATT GATT/SR/GAR/BI-15-C PASS GATT GATT/SR/GAR/BI-16-C PASS GATT GATT/SR/GAR/BI-17-C PASS GATT GATT/SR/GAR/BI-18-C PASS GATT GATT/SR/GAR/BI-19-C PASS GATT GATT/SR/GAR/BI-20-C PASS GATT GATT/SR/GAR/BI-21-C PASS GATT GATT/SR/GAR/BI-22-C PASS GATT GATT/SR/GAR/BI-36-C PASS GATT GATT/SR/GAR/BI-38-C PASS GATT GATT/SR/GAR/BI-40-C PASS GATT GATT/SR/GAR/BI-42-C PASS GATT GATT/SR/GAR/BI-44-C PASS GATT GATT/SR/GAR/BI-45-C PASS GATT GATT/SR/GAR/BV-01-C PASS GATT GATT/SR/GAR/BV-03-C PASS GATT GATT/SR/GAR/BV-04-C PASS GATT GATT/SR/GAR/BV-05-C PASS GATT GATT/SR/GAR/BV-06-C PASS GATT GATT/SR/GAR/BV-07-C PASS GATT GATT/SR/GAR/BV-08-C PASS GATT GATT/SR/GAR/BV-09-C PASS GATT GATT/SR/GAR/BV-11-C PASS GATT GATT/SR/GAS/BV-01-C PASS GATT GATT/SR/GAS/BV-03-C PASS GATT GATT/SR/GAT/BV-01-C PASS GATT GATT/SR/GAW/BI-02-C PASS GATT GATT/SR/GAW/BI-03-C PASS GATT GATT/SR/GAW/BI-04-C PASS GATT GATT/SR/GAW/BI-05-C PASS GATT GATT/SR/GAW/BI-06-C PASS GATT GATT/SR/GAW/BI-07-C PASS GATT GATT/SR/GAW/BI-08-C PASS GATT GATT/SR/GAW/BI-09-C PASS GATT GATT/SR/GAW/BI-12-C PASS GATT GATT/SR/GAW/BI-13-C PASS GATT GATT/SR/GAW/BI-32-C PASS GATT GATT/SR/GAW/BI-33-C PASS GATT GATT/SR/GAW/BI-39-C PASS GATT GATT/SR/GAW/BV-01-C PASS GATT GATT/SR/GAW/BV-03-C PASS GATT GATT/SR/GAW/BV-05-C PASS GATT GATT/SR/GAW/BV-06-C PASS GATT GATT/SR/GAW/BV-07-C PASS GATT GATT/SR/GAW/BV-08-C PASS GATT GATT/SR/GAW/BV-09-C PASS GATT GATT/SR/GAW/BV-10-C PASS GATT GATT/SR/GAW/BV-11-C PASS GATT GATT/SR/GPM/BV-05-C PASS GATT GATT/SR/UNS/BI-01-C PASS GATT GATT/SR/UNS/BI-02-C PASS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one of the requested characteristic values filled the MTU, this caused the while loop to exit early. As a result, we skipped checking remaining handles and incorrectly retuned a succesful response even when the remaining handles were invalid.
-Move MTU check from while loop into the loop body to enforce validation on all requested handles.
-validate all requested handles event after MTU fills up
Fixes qualification test case GATT/SR/GAR/BI-38-C.