test(desktop): story-cover daily review empty, many-sessions, and long-report states - #4220
Open
liuxiaocs7 wants to merge 1 commit into
Open
test(desktop): story-cover daily review empty, many-sessions, and long-report states#4220liuxiaocs7 wants to merge 1 commit into
liuxiaocs7 wants to merge 1 commit into
Conversation
…, and long-report states Tenth surface under apache#3944 (one surface per PR): extend the Daily Review panel (DailyReviewPage, via Product/Module Hubs) with the states the existing Scheduled Daily Review stories never reach. - ScheduledDailyReviewEmpty — a day with no recorded activity: the panel's own empty overview. - ScheduledDailyReviewManySessions — the list caps at DAILY_REVIEW_LIST_LIMIT (8), so a higher total (12) surfaces as an 8-row list (review feedback: the array can't exceed the cap the coordinator picks and the decoder enforces). - ScheduledDailyReviewLongReport — view analysis on a report with long sections. - ScheduledDailyReviewGenerationFailed — generate returns a `failed` archive (model timeout/error); the report route shows the error Banner and failure message. Reachable via generate/retry, the only path to a failed archive (review feedback: it is reachable, so it is covered rather than omitted). Refs apache#3944, apache#3893 Generated-by: Claude Code
liuxiaocs7
force-pushed
the
liuxiaocs7/daily-review-failure-states
branch
from
August 29, 2026 21:23
5b2df5f to
19d5e8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(desktop): story-cover daily review empty, many-sessions, failure, and long-report states
Tenth surface under #3944 (one surface per PR): extend the Daily Review panel
(DailyReviewPage, via Product/Module Hubs) with the states the existing
Scheduled Daily Review stories never reach.
empty overview.
(8), so a higher total (12) surfaces as an 8-row list (review feedback: the
array can't exceed the cap the coordinator picks and the decoder enforces).
failedarchive(model timeout/error); the report route shows the error Banner and failure
message. Reachable via generate/retry, the only path to a failed archive
(review feedback: it is reachable, so it is covered rather than omitted).
Refs #3944, #3893
Generative tooling
Claude Code contributed substantially here — it authored these Storybook stories. The human contributor of record reviewed and submitted the change, and each commit carries a
Generated-by: Claude Codetrailer per CONTRIBUTING.md.Visual evidence
Storybook stories captured with Playwright (hosted on the fork's release assets).
scheduled-daily-review-empty— normal / light · narrow / darkscheduled-daily-review-many-sessions— normal / light · narrow / darkscheduled-daily-review-long-report— normal / light · narrow / darkscheduled-daily-review-generation-failed— normal / light · narrow / dark