test(desktop): story-cover browser panel edge and navigation-failure states - #4217
Merged
Astro-Han merged 1 commit intoAug 30, 2026
Merged
Conversation
…states Ninth surface under apache#3944 (one surface per PR): extend the 浏览器 panel (via Product/Session Workbar) with the reachable states the existing Browser* stories never show. BrowserState carries no error/crashed field — a failed load re-emits the same seven fields — so the panel has no error render branch; its only real failure affordances are the two navigation toasts. - BrowserCanGoForward — the one nav-control combination never shown: forward enabled, not just back. - BrowserLongUrl — a very long URL + title at the 320px column floor, so the address field keeps the URL legible. - BrowserInvalidAddress — a non-HTTP(S) address is rejected before navigating and raises the "无法打开地址" toast. - BrowserNavigationFailed — a valid address whose navigate rejects raises the "浏览器导航失败" toast. `bridge()` gains a `browserNavigateFails` option (navigate rejects) in the same idiom as the existing task/review overrides. No error/crashed/blocked/offline render state exists on this surface, so none is faked. Refs apache#3944, apache#3893 Generated-by: Claude Code
liuxiaocs7
force-pushed
the
liuxiaocs7/browser-panel-failure-states
branch
from
August 29, 2026 21:37
264a785 to
577e2b4
Compare
Astro-Han
reviewed
Aug 30, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
Synthesis at exact head 577e2b4c82d0b5a612eb8d9844a9d3be5a5738a1 (577e2b4) — test(desktop): story-cover browser panel edge and navigation-failure states.
All findings in this comment are from @DSv4F-Qronos-AstroHan independent review at this exact head. I did not read this diff myself; I verified that the current head has not drifted and the exact-head CI status is green (test SUCCESS 20m48s, MERGEABLE per Luna re-check).
Actual change (per reviewer, 1 file +111, 4 stories)
bridge()addsbrowserNavigateFailsoption to simulatebrowser.navigatereject.- Stories:
BrowserCanGoForward(canGoForward true → enabled),BrowserLongUrl(long URL at 320px width),BrowserInvalidAddress(mailto: → toast无法打开地址),BrowserNavigationFailed(navigate reject → toast浏览器导航失败). - Copy keys verified:
browser-copy.ts:51openFailed,:52navigationFailed,:59forwardAria,:65addressAria.
Gate
- Code: GO, no P0–P2 (1×P3 low risk:
BrowserLongUrlasserts value only, not toolbar overflow; acceptable per story visual snapshot convention). - CI: exact-head
testSUCCESS (20m48s),MERGEABLEbutBLOCKED/REVIEW_REQUIRED(no prior review, branch protection requires approval, not code conflict). - No CONFLICTING, no prior automated APPROVED to misinterpret.
What this synthesis could not verify
- No local Storybook run on this head by synthesizer; relied on reviewer's code-path deduction and hosted CI. Visual snapshot pipeline not re-run here.
Automated review notice: This comment was posted by an automated review agent operated by Astro-Han. It is not an independent human review and does not replace one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(desktop): story-cover browser panel edge and navigation-failure states
Ninth surface under #3944 (one surface per PR): extend the 浏览器 panel (via
Product/Session Workbar) with the reachable states the existing Browser* stories
never show. BrowserState carries no error/crashed field — a failed load re-emits
the same seven fields — so the panel has no error render branch; its only real
failure affordances are the two navigation toasts.
enabled, not just back.
address field keeps the URL legible.
and raises the "无法打开地址" toast.
"浏览器导航失败" toast.
bridge()gains abrowserNavigateFailsoption (navigate rejects) in the sameidiom as the existing task/review overrides. No error/crashed/blocked/offline
render state exists on this surface, so none is faked.
Refs #3944, #3893
Generative tooling
Claude Code contributed substantially here — it authored these Storybook stories. The human contributor of record reviewed and submitted the change, and each commit carries a
Generated-by: Claude Codetrailer per CONTRIBUTING.md.Visual evidence
Storybook stories captured with Playwright (hosted on the fork's release assets).
browser-can-go-forward— normal / light · narrow / darkbrowser-long-url— normal / light · narrow / darkbrowser-invalid-address— normal / light · narrow / darkbrowser-navigation-failed— normal / light · narrow / dark