test(desktop): story-cover agent graph failure and edge states - #4212
Open
liuxiaocs7 wants to merge 1 commit into
Open
test(desktop): story-cover agent graph failure and edge states#4212liuxiaocs7 wants to merge 1 commit into
liuxiaocs7 wants to merge 1 commit into
Conversation
Seventh surface under apache#3944 (one surface per PR): the Agent Graph panel had no Storybook story. Add its failure and edge states, mounted through a scoped `window.maka.graphs` bridge inside the real composer host seam (.maka-detail-with-artifacts → .mainColumn), each pinning one AgentGraphClientSnapshot. - EmptyGraph — graph mode enabled, no operators yet: the panel's empty state. - FailedGraph — a failed operator beside completed/running ones. - BlockedOnUpstream — a blocked operator with the amber "waiting for input" line. - ManyOperators — a wide fan-out (28 operators) with no fabricated omitted count (the read-model only elides operators past 256) — review feedback. - LoadError — the IPC snapshot read rejects: the panel's error Banner + Retry. The panel renders operators as a flat list (no edges/hierarchy), so tree depth and cycles have no distinct rendering and are left out. Plays assert reachability of each state; exact row counts / omitted lines are read-model contracts left to the read-model's own tests (review feedback). Refs apache#3944, apache#3893 Generated-by: Claude Code
liuxiaocs7
force-pushed
the
liuxiaocs7/agent-graph-failure-states
branch
from
August 29, 2026 21:28
5797b53 to
4de018d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(desktop): story-cover agent graph failure and edge states
Seventh surface under #3944 (one surface per PR): the Agent Graph panel had no
Storybook story. Add its failure and edge states, mounted through a scoped
window.maka.graphsbridge inside the real composer host seam(.maka-detail-with-artifacts → .mainColumn), each pinning one
AgentGraphClientSnapshot.
(the read-model only elides operators past 256) — review feedback.
The panel renders operators as a flat list (no edges/hierarchy), so tree depth
and cycles have no distinct rendering and are left out. Plays assert
reachability of each state; exact row counts / omitted lines are read-model
contracts left to the read-model's own tests (review feedback).
Refs #3944, #3893
Generative tooling
Claude Code contributed substantially here — it authored these Storybook stories. The human contributor of record reviewed and submitted the change, and each commit carries a
Generated-by: Claude Codetrailer per CONTRIBUTING.md.Visual evidence
Storybook stories captured with Playwright (hosted on the fork's release assets).
empty-graph— normal / light · narrow / darkfailed-graph— normal / light · narrow / darkblocked-on-upstream— normal / light · narrow / darkmany-operators— normal / light · narrow / darkload-error— normal / light · narrow / dark