test(desktop): story-cover chat transcript failure and edge states - #4211
Open
liuxiaocs7 wants to merge 1 commit into
Open
test(desktop): story-cover chat transcript failure and edge states#4211liuxiaocs7 wants to merge 1 commit into
liuxiaocs7 wants to merge 1 commit into
Conversation
Sixth surface under apache#3944 (one surface per PR): extend the chat transcript (ChatView → materializeTurns → TurnView, via Product/Shell Official AppShell) with the failure and edge states that never show up in normal use. All feed a real message ledger through ComposedShell, like InterruptedToolAfterTurnAbort. - FailedTurnWithToolError — a tool call errors mid-turn and the turn settles `failed`: the errored tool row plus the failed Banner + erroredTool description. - ProviderRateLimited — a settled `failed` turn with errorClass 'rate_limit'. - ProviderRetrying — a live turn whose providerRetry swaps the working phrase for the ModelProviderRetryIndicator banner. - SafeResumeAfterRestart — the last turn failed with errorClass 'app_restarted', offering the warning-severity Banner with the 继续这一轮 safe-resume button. - ManyTurns — 120 turns, past the transcript virtualizer's window (review feedback: 20 did not guarantee the virtualization path). Streaming, aborted/interrupted, empty, and long-message states were already covered, so this adds only the genuinely missing ones. All are safe presentational states driven by the message ledger and live overlay. Refs apache#3944, apache#3893 Generated-by: Claude Code
liuxiaocs7
force-pushed
the
liuxiaocs7/chat-rendering-failure-states
branch
from
August 29, 2026 21:31
f63b424 to
a3cdcfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(desktop): story-cover chat transcript failure and edge states
Sixth surface under #3944 (one surface per PR): extend the chat transcript
(ChatView → materializeTurns → TurnView, via Product/Shell Official AppShell)
with the failure and edge states that never show up in normal use. All feed a
real message ledger through ComposedShell, like InterruptedToolAfterTurnAbort.
failed: the errored tool row plus the failed Banner + erroredTool description.failedturn with errorClass 'rate_limit'.for the ModelProviderRetryIndicator banner.
offering the warning-severity Banner with the 继续这一轮 safe-resume button.
feedback: 20 did not guarantee the virtualization path).
Streaming, aborted/interrupted, empty, and long-message states were already
covered, so this adds only the genuinely missing ones. All are safe
presentational states driven by the message ledger and live overlay.
Refs #3944, #3893
Generative tooling
Claude Code contributed substantially here — it authored these Storybook stories. The human contributor of record reviewed and submitted the change, and each commit carries a
Generated-by: Claude Codetrailer per CONTRIBUTING.md.Visual evidence
Storybook stories captured with Playwright (hosted on the fork's release assets).
failed-turn-with-tool-error— normal / light · narrow / darkprovider-rate-limited— normal / light · narrow / darkprovider-retrying— normal / light · narrow / darksafe-resume-after-restart— normal / light · narrow / darkmany-turns— normal / light · narrow / dark