Skip to content

perf(ui): scope prompt rail observation to mounted turns #4203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 1 commit into from
Aug 30, 2026
+4 −3
Merged

perf(ui): scope prompt rail observation to mounted turns #4203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/ui/src/prompt-anchor-rail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,8 @@ export const PromptAnchorRail = memo(function PromptAnchorRail({ turns, scrollRe

useEffect(() => {
const root = scrollRef.current;
if (!root || turns.length === 0) return;
const mountedTurnList = root?.querySelector('[data-virtual-turn-id]')?.parentElement;
if (!root || !mountedTurnList || turns.length === 0) return;

const idByElement = new Map<Element, string>();
const visible = new Set<string>();
Expand Down Expand Up @@ -381,7 +382,7 @@ export const PromptAnchorRail = memo(function PromptAnchorRail({ turns, scrollRe
},
{ root, rootMargin: '0px 0px -66% 0px', threshold: 0 },
);
for (const element of root.querySelectorAll('[data-turn-id]')) observeElement(element);
for (const element of mountedTurnList.querySelectorAll('[data-turn-id]')) observeElement(element);

const mutationObserver = new MutationObserver((records) => {
for (const record of records) {
Expand All @@ -390,7 +391,7 @@ export const PromptAnchorRail = memo(function PromptAnchorRail({ turns, scrollRe
}
resolveActive();
});
mutationObserver.observe(root, { childList: true, subtree: true });
mutationObserver.observe(mountedTurnList, { childList: true });
Comment thread
Astro-Han marked this conversation as resolved.

let frame = 0;
const onScroll = (): void => {
Expand Down