feat(desktop): approve guest Turn requests - #4198
Draft
M4n5ter wants to merge 1 commit into
Draft
Conversation
M4n5ter
force-pushed
the
feat/desktop-turn-approval
branch
from
August 29, 2026 17:30
119a0c2 to
d39669b
Compare
Complete the Desktop collaboration loop with Guest Turn requests, durable Owner decisions, and fail-closed read-only behavior when authority is absent. Generated-by: OpenAI Codex
M4n5ter
force-pushed
the
feat/desktop-turn-approval
branch
from
August 29, 2026 18:04
d39669b to
7da5407
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English
Summary
Complete the Desktop collaboration loop: a Guest with request authority can submit a Turn request and follow its status, while the Owner can approve or reject pending requests. Local-only Sessions no longer expose a sharing action that cannot produce a reachable Guest connection.
Refs #3843
Verification
npm --workspace @maka/runtime-host run typechecknpm --workspace @maka/desktop run typechecknode --test packages/runtime-host/dist/__tests__/session-collaboration-authority.test.js packages/runtime-host/dist/__tests__/session-catalog-protocol.test.js packages/runtime-host/dist/__tests__/authenticated-websocket.test.js(38 passed)AI use
Tool(s) and scope: OpenAI Codex implemented and verified the change under the maintainer's direction and review.
Checklist
Does this PR entail a change in behavior?
中文
摘要
完成 Desktop 协作闭环:拥有请求 authority 的 Guest 可提交 Turn 请求并查看状态,Owner 可批准或拒绝待处理请求。仅 Local 的 Session 不再显示无法产生可达 Guest 连接的分享操作。
关联 #3843
验证
npm --workspace @maka/runtime-host run typechecknpm --workspace @maka/desktop run typechecknode --test packages/runtime-host/dist/__tests__/session-collaboration-authority.test.js packages/runtime-host/dist/__tests__/session-catalog-protocol.test.js packages/runtime-host/dist/__tests__/authenticated-websocket.test.js(38 项通过)AI 使用
OpenAI Codex 在维护者的指导和审核下参与了实现与验证。