feat(runtime-host): scope shared session observation - #4195
Merged
Conversation
M4n5ter
force-pushed
the
feat/shared-session-observation
branch
from
August 29, 2026 17:30
bb0fb53 to
353d95f
Compare
M4n5ter
force-pushed
the
feat/shared-session-observation
branch
from
August 29, 2026 18:04
353d95f to
4ea2455
Compare
M4n5ter
force-pushed
the
feat/shared-session-observation
branch
from
August 29, 2026 21:51
4ea2455 to
0506602
Compare
M4n5ter
marked this pull request as ready for review
August 29, 2026 23:34
jackwener
approved these changes
Aug 29, 2026
jackwener
left a comment
Member
There was a problem hiding this comment.
I reviewed exact head 0506602426b1ccba402388d60ff27082fc92eef7 and found no blocking issue. Shared Session discovery is derived from the authenticated Guest's active observation grant; transcript, subscription, runtime-resource, and Artifact reads recheck that grant across asynchronous boundaries; revocation closes the live subscription; and the shared transcript projection removes Owner-only composition and full tool arguments. The full stacked Runtime Host suite and all changed-area checks pass.
Automated review notice: This comment was posted by an automated review agent operated by WAWQAQ. It is not an independent human review and does not replace one.
Expose a Host-private-field-free shared Session projection and grant-fenced transcript and live subscriptions, including immediate closure after observation revocation. Generated-by: OpenAI Codex
M4n5ter
force-pushed
the
feat/shared-session-observation
branch
from
August 30, 2026 00:14
0506602 to
1ffe07d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English
Summary
Expose only granted Sessions to a Guest and enforce the same observation grant on transcript queries and live subscriptions. Revocation closes the active observation stream and removes stale reconnect intent.
Refs #3843
Verification
npm run build:testnode --test packages/runtime-host/dist/__tests__/authenticated-websocket.test.js packages/runtime-host/dist/__tests__/session-catalog-protocol.test.jsnpm run lintnpm run format:checkAI use
Tool(s) and scope: OpenAI Codex implemented and verified the change under the maintainer's direction and review.
Checklist
Does this PR entail a change in behavior?
中文
摘要
只向 Guest 投影已授予的 Session,并在 transcript 查询与实时订阅上执行同一 observation grant。撤销会关闭活跃观察流,并清除过期的重连意图。
关联 #3843
验证
npm run build:testnode --test packages/runtime-host/dist/__tests__/authenticated-websocket.test.js packages/runtime-host/dist/__tests__/session-catalog-protocol.test.jsnpm run lintnpm run format:checkAI 使用
OpenAI Codex 在维护者的指导和审核下参与了实现与验证。