Skip to content

Port log4j-core-test migration to JUnit 5 into main#3289

Open
AlbaHerrerias wants to merge 18 commits intoapache:mainfrom
neighbourhoodie:main-log4j-core-test-migration-junit-5
Open

Port log4j-core-test migration to JUnit 5 into main#3289
AlbaHerrerias wants to merge 18 commits intoapache:mainfrom
neighbourhoodie:main-log4j-core-test-migration-junit-5

Conversation

@AlbaHerrerias
Copy link
Copy Markdown
Contributor

We are from Neighbourhoodie, the implementation partner of the STF Bug Resilience Program. This work is part of our agreed Milestone 1. Upgrade from JUnit 4 to JUnit 5. This PR takes the changes introduced in this PR and ports them into the main branch, as requested.

Most of the changes were not suitable:

  • Many tests in main were already in JUnit 5
  • The tests were not equal between 2.x and main (the tests in main need a separate and dedicated refactor)
  • 2.x has test suites not present in main

Thank you!

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 13, 2024

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 Build Scan PUBLISHED
Generated by gradle/develocity-actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To triage

Development

Successfully merging this pull request may close these issues.

2 participants