Replace the SDK test JAR with a flume-ng-sdk-test module - #495
Merged
Conversation
The site build runs `mvnw -Dmaven.test.skip install`, which also skips `jar:test-jar`. Maven still resolves the full test classpath before `compiler:testCompile` and `surefire:test` can read their skip flags, so the cross-module `flume-ng-sdk:tests` dependency was demanded but never produced and `deploy-site` failed to resolve it. Assisted-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WnSh7gt5XaRzNgDYLuFzZ6
rgoers
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
deploy-sitefailures ontrunk.The reusable site workflow builds with
mvnw -Dmaven.test.skip install. That flag also skipsjar:test-jar, soflume-ng-sdknever attaches its tests JAR — while Maven still resolves the full test classpath beforecompiler:testCompileandsurefire:testcan read their skip flags. Theflume-ng-sdk:testsdependency was therefore demanded but never produced, and resolution fell through to the repositories.This PR applies the same convention Log4j has been using: reusable test classes have their own artifact with a name ending suffiexed by
-test.