Run install before generating the site - #490
Merged
Merged
Conversation
The `site` lifecycle packages no jars, so the reactor's SNAPSHOT dependencies only resolved when the shared Maven cache happened to contain them from a previous snapshot deploy job. Assisted-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016zsFn1f2B32vcNoCeZSfn7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
deploy-siteworkflow fails to resolve the reactor's own2.0.0-SNAPSHOTartifacts: thesitelifecycle does not package any jars, so Maven falls back to remote repositories, where no snapshot repository is configured. Past runs only succeeded when the sharedsetup-javaMaven cache happened to contain artifacts installed by a previous snapshot deploy job; any POM change rotates the cache key and breaks the build.Setting
install-required: truemakes the reusable workflow run./mvnw -Dmaven.test.skip installbeforesite, so the site is generated against the jars of the commit being built. This matches whatlogging-log4j2already does.In the long term, the duplicate build could be avoided by adding a
reference-artifact-name-style parameter todeploy-site-reusable.yaml(as inverify-reproducibility-reusable.yaml), so the site build can reuse the Maven repository produced by the build that deployed the snapshot.