MINOR: Cleanup additional dead code missed during stateupdater refactoring #21157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashankhs11
commented
Dec 15, 2025
| * @throws StreamsException if the store's change log does not contain the partition | ||
| * @return {@code true} if all tasks are fully restored | ||
| */ | ||
| boolean tryToCompleteRestoration(final long now, |
Member
|
@shashankhs11 needs rebase |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up dead code that was missed during the state updater refactoring. The changes remove unused methods, method parameters, test mock fields, and imports that are no longer needed after the refactoring.
Key changes:
- Removed two large unused methods from TaskManager (
tryToCompleteRestorationandneedsInitializationOrRestoration) that were replaced by state updater functionality - Cleaned up unused method parameters in test and production code
- Removed unused mock fields and variables from test classes
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| TaskManager.java | Removed unused tryToCompleteRestoration method (77 lines), needsInitializationOrRestoration method, addTask test helper method, and unused LinkedList import |
| StreamThread.java | Removed unused initializeAndRestorePhase method (32 lines) and removed unused log and threadId parameters from setupMainConsumer method |
| StreamThreadStateStoreProviderTest.java | Removed unused Admin import and removed unused restoreConsumer and adminClient parameters from createStreamsTask helper method |
| TaskManagerTest.java | Removed unused ProcessorStateManager mock field |
| StreamThreadTest.java | Removed unused task3 TaskId field variable |
| ActiveTaskCreatorTest.java | Removed unused ChangelogReader mock field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shashankhs11
force-pushed
the
unused-code-cleanup
branch
from
9047050 to
c694e43
Compare
Contributor
Author
@lucasbru, done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: Lucas Brutschy lbrutschy@confluent.io