APIs for Follower Fetch from Last Tiered Offset #21153
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
abhijeetk88
changed the title
kamalcph
reviewed
Dec 16, 2025
|
|
||
| if (localLogStartOffset.offset() == logStartOffset.offset()) { | ||
| // No segments have been uploaded yet | ||
| return logStartOffset; |
Contributor
There was a problem hiding this comment.
can we refactor the code to avoid using multiple return statements?
| import scala.collection.Map | ||
| import scala.jdk.CollectionConverters._ | ||
|
|
||
| class LocalLeaderEndPointRemoteTest extends LocalLeaderEndPointTestBase { |
Contributor
There was a problem hiding this comment.
Why do we have to split the test? Can they be part of the existing LocalLeaderEndPointTest itself?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete this text and replace it with a detailed description of your
change. The PR title and body will become the squashed commit message.
If you would like to tag individuals, add some commentary, upload
images, or include other supplemental information that should not be
part of the eventual commit message, please use a separate comment.
If applicable, please include a summary of the testing strategy
(including rationale) for the proposed change. Unit and/or integration
tests are expected for any behavior change and system tests should be
considered for larger changes.