Skip to content

Handle empty EarliestCommitToRetain#732

Merged
vinishjail97 merged 3 commits intoapache:mainfrom
alexr17:alexr/handle-earliest-commit-to-retain-empty
Apr 8, 2026
Merged

Handle empty EarliestCommitToRetain#732
vinishjail97 merged 3 commits intoapache:mainfrom
alexr17:alexr/handle-earliest-commit-to-retain-empty

Conversation

@alexr17
Copy link
Copy Markdown
Contributor

@alexr17 alexr17 commented Jul 16, 2025

Important Read

  • Please ensure the GitHub issue is mentioned at the beginning of the PR

What is the purpose of the pull request

If the earliest commit to retain is empty (rare occurrences):

  • Get all instants after lastSyncedInstant.
  • If no clean instants since lastSyncedInstant, we do incremental sync.
  • Otherwise if earliestCommitToRetain.isEmpty() and there are clean instants, do a full snapshot sync to err on the side of caution.

Brief change log

Handles case when earliest commit to retain is empty or null

Verify this pull request

This change added tests and can be verified as follows:

  • Added unit tests

@vinishjail97 vinishjail97 merged commit 2ae9642 into apache:main Apr 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants