Skip to content

Conversation

@HeartLinked
Copy link
Contributor

@HeartLinked HeartLinked commented Dec 25, 2025

close #392 .
close #396 .
close #394 .

Comment on lines +356 to +358
return Table::Make(identifier, load_result.metadata,
std::move(load_result.metadata_location), file_io_,
non_const_catalog);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return Table::Make(identifier, load_result.metadata,
std::move(load_result.metadata_location), file_io_,
non_const_catalog);
return Table::Make(identifier, std::move(load_result.metadata),
std::move(load_result.metadata_location), file_io_,
std::move(non_const_catalog));

Comment on lines +149 to +152
auto partition_spec_result =
PartitionSpec::Make(PartitionSpec::kInitialSpecId, {}, 0);
EXPECT_THAT(partition_spec_result, IsOk());
return {std::move(*partition_spec_result)};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto partition_spec_result =
PartitionSpec::Make(PartitionSpec::kInitialSpecId, {}, 0);
EXPECT_THAT(partition_spec_result, IsOk());
return {std::move(*partition_spec_result)};
return PartitionSpec::Unpartitioned();

Comment on lines +157 to +160
auto sort_order_result =
SortOrder::Make(SortOrder::kUnsortedOrderId, std::vector<SortField>{});
EXPECT_THAT(sort_order_result, IsOk());
return {std::move(*sort_order_result)};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto sort_order_result =
SortOrder::Make(SortOrder::kUnsortedOrderId, std::vector<SortField>{});
EXPECT_THAT(sort_order_result, IsOk());
return {std::move(*sort_order_result)};
return SortOrder:Unsorted();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement LoadTable for REST catalog Implement TableExists for REST catalog Implement DropTable for REST catalog

3 participants