perf: use shallow projection where applicable #17682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@hudi-bot run azure |
1 similar comment
Contributor
|
@hudi-bot run azure |
Contributor
Author
|
@danny0405 Please take a look |
cshuo
reviewed
Dec 25, 2025
| } else { | ||
| GenericData.Record rec = new GenericData.Record(targetSchema); | ||
| for (Schema.Field field : targetSchema.getFields()) { | ||
| if (record.hasField(field.name())) { |
Collaborator
There was a problem hiding this comment.
record.hasField and record.get will both search field in the internal schema, suggested changes.
Field sourceField = record.getSchema().getField(field.name());
if (sourceField == null) {
rec.put(field.pos(), null);
} else {
rec.put(field.pos(), record.get(sourceField.pos()));
}
kamronis
force-pushed
the
master
branch
2 times, most recently
from
82f4c1c to
7a08b71
Compare
Contributor
Author
|
@danny0405 @cshuo |
cshuo
reviewed
Dec 29, 2025
| * the schemas are identical in field count. | ||
| */ | ||
|
|
||
| public static GenericRecord projectRecordToNewSchemaShallow(GenericRecord record, Schema targetSchema) { |
Collaborator
There was a problem hiding this comment.
it's safer to keep the parameter type as IndexedRecord like rewriteRecordWithNewSchema, avoiding unnecessary type coercion in HoodieAvroRecord.
Collaborator
Collaborator
|
thks for contributing, lgtm. |
wombatu-kun
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
This closes #17679
Move optimized method for shallow copy with new schema to utils and use it where applicable.
Summary and Changelog
Searched
HoodieAvroUtils.rewriteRecordWithNewSchemacalls and found one class with dead code and one class where function can be applied for prepending metadata.Impact
Performance improve
Risk Level
None
Documentation Update
None
Contributor's checklist