Skip to content

[FLINK-40528][table] Make codegen tolerant to partial deletes #29060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snuyanzin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[FLINK-40528][table] Make codegen tolerant to partial deletes #29060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
589bd9f
[FLINK-40528][table] Make codegen tolerat to partial deletes
snuyanzin Aug 31, 2026
749d1c4
Address feedback
snuyanzin Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...nk-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ object CodeGenUtils {
s"$rowTerm.setNullAt($indexTerm)"
}

if (fieldType.isNullable) {
if (fieldType.isNullable || !fieldExpr.isProvenNotNull) {
s"""
|${fieldExpr.code}
|if (${fieldExpr.nullTerm}) {
Expand Down
3 changes: 3 additions & 0 deletions ...e-planner/src/main/scala/org/apache/flink/table/planner/codegen/GeneratedExpression.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ case class GeneratedExpression(
*/
def literal: Boolean = literalValue.isDefined

/** Whether this expression is statically proven never to be null at runtime. */
def isProvenNotNull: Boolean = nullTerm == GeneratedExpression.NEVER_NULL

/**
* Copy result term to target term if the reference is changed. Note: We must ensure that the
* target can only be copied out, so that its object is definitely a brand new reference, not the
Expand Down
17 changes: 8 additions & 9 deletions ...ble-planner/src/main/scala/org/apache/flink/table/planner/codegen/JsonGenerateUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,15 +142,14 @@ object JsonGenerateUtils {

val valueNodeTerm = createNodeTerm(ctx, fieldAccessTerm, fieldType)

if (fieldType.isNullable) {
s"""
|$containerTerm.isNullAt($indexTerm) ?
| (${className[JsonNode]}) $nodeFactoryTerm.nullNode() :
| (${className[JsonNode]}) $valueNodeTerm
|""".stripMargin
} else {
valueNodeTerm
}
// The declared type may be NOT NULL while the runtime container still carries null, e.g. a
// delete-by-key tombstone. Always guard on isNullAt so such nulls serialize as JSON null
// instead of reading a primitive default.
s"""
|$containerTerm.isNullAt($indexTerm) ?
| (${className[JsonNode]}) $nodeFactoryTerm.nullNode() :
| (${className[JsonNode]}) $valueNodeTerm
|""".stripMargin
}

/**
Expand Down
6 changes: 3 additions & 3 deletions ...nner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1226,7 +1226,7 @@ object ScalarOperatorGens {
val tpe = fieldTypes(idx)
if (element.literal) {
""
} else if (tpe.isNullable) {
} else if (tpe.isNullable || !element.isProvenNotNull) {
s"""
|${element.code}
|if (${element.nullTerm}) {
Expand Down Expand Up @@ -1275,7 +1275,7 @@ object ScalarOperatorGens {
.map {
case (element, idx) =>
val tpe = fieldTypes(idx)
if (tpe.isNullable) {
if (tpe.isNullable || !element.isProvenNotNull) {
s"""
|${element.code}
|if (${element.nullTerm}) {
Expand Down Expand Up @@ -1350,7 +1350,7 @@ object ScalarOperatorGens {
case (element, idx) =>
if (element.literal) {
""
} else if (elementType.isNullable) {
} else if (elementType.isNullable || !element.isProvenNotNull) {
s"""
|${element.code}
|if (${element.nullTerm}) {
Expand Down
Loading