[FLINK-40519][network] Deliver priority barrier to a credited remote reader while the subpartition is blocked during recovery - #29056
Open
1996fanrui wants to merge 1 commit into
Open
Conversation
…reader while the subpartition is blocked during recovery
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
A blocked
PipelinedSubpartitionstill hands out priority buffers (unaligned-checkpoint barriers) inpollBuffer(), butisDataAvailableUnsafe()andgetBuffersInBacklogUnsafe()still gate on!isBlocked.A credited remote reader decides availability through those methods, so its one-shot priority notification
is evaluated as "not available", the reader is not enqueued, and the barrier is not delivered until recovery
ends (
resumeConsumption()) — the checkpoint can time out. The local channel path is already handled viahasPendingPriorityEvent; the remote path was not.Brief change log
PipelinedSubpartition#isBlockedForDelivery()and use it inpollBuffer,isDataAvailableUnsafeandgetBuffersInBacklogUnsafeso a queued priority barrier is delivered to a credited reader while the subpartition is blocked.Verifying this change
This change added a unit test:
PipelinedSubpartitionTestcase asserting that, while blocked with a priority barrier queued, the credited-reader availability check reports available and the barrier is pollable.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?